ADFA-4936: Fix Jacoco/SonarQube workflow (plugin-manager compile + lsp:kotlin OOM)

lsp/kotlin/src/test/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/AnalysisSerializationTest.kt

@@ -38,7 +38,7 @@ import kotlin.math.max
  * preemption, and reentrancy behaviour.
  */
 class AnalysisSerializationTest : KtLspTest() {
-	@Test
+	@Test(timeout = 60_000)
 	fun `concurrent analyzeMaybeDangling never throws lifetime exception`(): Unit =
 		runBlocking {
 			val files =
@@ -86,7 +86,7 @@ class AnalysisSerializationTest : KtLspTest() {
 			assertThat(errors).isEmpty()
 		}
 
-	@Test
+	@Test(timeout = 60_000)
 	fun `analyzeMaybeDangling serializes overlapping analyses`(): Unit =
 		runBlocking {
 			val files =

lsp/kotlin/src/test/java/com/itsaky/androidide/lsp/kotlin/fixtures/KtLspTestRule.kt

@@ -7,31 +7,35 @@ import org.junit.runner.Description
 import org.junit.runners.model.Statement
 
 internal class KtLspTestRule : TestRule {
-
 	val tempDir = TemporaryFolder()
 	lateinit var env: KtLspTestEnvironment
 		private set
 
 	override fun apply(
 		statement: Statement?,
-		description: Description?
-	): Statement {
-		return tempDir.apply(object : Statement() {
-			override fun evaluate() {
-				try {
-					val sourceRoot = tempDir.newFolder("src").toPath()
-					env = KtLspTestEnvironment(listOf(sourceRoot))
+		description: Description?,
+	): Statement =
+		tempDir.apply(
+			object : Statement() {
+				override fun evaluate() {
+					try {
+						val sourceRoot = tempDir.newFolder("src").toPath()
+						env = KtLspTestEnvironment(listOf(sourceRoot))
 
-					statement?.evaluate()
-				} finally {
-					if (::env.isInitialized) {
-						env.project.write {
-							// TODO: This fails in test cases, ignored for now
-							// env.close()
+						statement?.evaluate()
+					} finally {
+						if (::env.isInitialized) {
+							// Dispose each test's heavy Analysis-API environment (IntelliJ project,
+							// application env, background index workers). Without this the per-method
+							// environments accumulate for the JVM's lifetime and the suite eventually
+							// exhausts the heap (ADFA-4936). close() manages its own threading/locking,
+							// so it must NOT run inside project.write { } -- that nesting was the
+							// original "fails in test cases" failure.
+							env.close()
 						}
 					}
 				}
-			}
-		}, description)
-	}
-}
+			},
+			description,
+		)
+}

plugin-manager/src/test/kotlin/com/itsaky/androidide/plugins/manager/E2EIntegrationTest.kt

@@ -1,87 +1,68 @@
 package com.itsaky.androidide.plugins.manager
 
-import com.itsaky.androidide.plugins.services.IdeFileService
-import com.itsaky.androidide.plugins.services.IdeResourceService
+import com.itsaky.androidide.plugins.PluginPermission
 import com.itsaky.androidide.plugins.manager.context.ServiceRegistryImpl
-import com.itsaky.androidide.plugins.manager.services.FileServiceImpl
-import com.itsaky.androidide.plugins.manager.services.ProjectServiceImpl
-import com.itsaky.androidide.plugins.manager.services.ResourceServiceImpl
-import org.junit.Test
-import org.junit.Assert.*
-import org.junit.Before
+import com.itsaky.androidide.plugins.manager.services.IdeFileServiceImpl
+import com.itsaky.androidide.plugins.services.IdeFileService
 import org.junit.After
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertNotNull
+import org.junit.Assert.assertTrue
+import org.junit.Before
+import org.junit.Test
 import java.io.File
 
 class E2EIntegrationTest {
+	private lateinit var tempProjectRoot: File
 
-    private lateinit var tempProjectRoot: File
-
-    @Before
-    fun setUp() {
-        tempProjectRoot = File.createTempFile("e2e-test-", "").apply {
-            delete()
-            mkdirs()
-        }
-    }
-
-    @After
-    fun tearDown() {
-        tempProjectRoot.deleteRecursively()
-    }
-
-    @Test
-    fun testCompletePluginWorkflow() {
-        // Simulate realistic plugin scenario:
-        // 1. Create a source file
-        // 2. Add a dependency to build.gradle.kts
-        // 3. Read resource strings
+	@Before
+	fun setUp() {
+		tempProjectRoot =
+			File.createTempFile("e2e-test-", "").apply {
+				delete()
+				mkdirs()
+			}
+	}
 
-        val serviceRegistry = ServiceRegistryImpl()
-        val fileService = FileServiceImpl(tempProjectRoot)
-        val projectService = ProjectServiceImpl(tempProjectRoot)
-        val resourceService = ResourceServiceImpl(tempProjectRoot)
+	@After
+	fun tearDown() {
+		tempProjectRoot.deleteRecursively()
+	}
 
-        serviceRegistry.register(IdeFileService::class.java, fileService)
-        serviceRegistry.register(IdeProjectService::class.java, projectService)
-        serviceRegistry.register(IdeResourceService::class.java, resourceService)
+	@Test
+	fun fileServiceWorkflowThroughRegistry() {
+		val registry = ServiceRegistryImpl()
+		val fileService =
+			IdeFileServiceImpl(
+				pluginId = "e2e-plugin",
+				permissions = setOf(PluginPermission.FILESYSTEM_WRITE),
+				pathValidator =
+					object : IdeFileServiceImpl.PathValidator {
+						override fun isPathAllowed(path: File) = path.isWithin(tempProjectRoot)
 
-        // Step 1: Create source file via FileService
-        val createResult = fileService.createFile(
-            "app/src/main/kotlin/com/example/Main.kt",
-            "package com.example\n\nfun main() {\n    println(\"Hello\")\n}"
-        )
-        assertTrue("Failed to create source file: ${createResult.error}", createResult.success)
+						override fun getAllowedPaths() = listOf(tempProjectRoot.absolutePath)
+					},
+			)
+		registry.register(IdeFileService::class.java, fileService)
 
-        // Step 2: Add dependency via ProjectService
-        val buildFile = File(tempProjectRoot, "app/build.gradle.kts")
-        buildFile.parentFile?.mkdirs()
-        buildFile.writeText("""
-            dependencies {
-                implementation("androidx.core:core-ktx:1.9.0")
-            }
-        """.trimIndent())
+		val resolved = registry.get(IdeFileService::class.java)
+		assertNotNull("IdeFileService should be retrievable from the registry", resolved)
 
-        val depResult = projectService.addDependency(
-            "app/build.gradle.kts",
-            "implementation(\"com.google.code.gson:gson:2.10.1\")"
-        )
-        assertTrue("Failed to add dependency: ${depResult.error}", depResult.success)
+		val sourceFile = File(tempProjectRoot, "app/src/main/kotlin/com/example/Main.kt")
+		val source = "package com.example\n\nfun main() {\n    println(\"Hello\")\n}"
 
-        val updatedBuildContent = buildFile.readText()
-        assertTrue("Dependency not added to build file", updatedBuildContent.contains("gson:2.10.1"))
+		assertTrue("write should succeed", resolved!!.writeFile(sourceFile, source))
+		assertEquals(source, resolved.readFile(sourceFile))
 
-        // Step 3: Access resource via ResourceService
-        val stringResult = resourceService.getString("app_name")
-        assertTrue("Failed to get string resource: ${stringResult.error}", stringResult.success)
-        assertNotNull("String resource data is null", stringResult.data)
+		val listed = resolved.listFiles(sourceFile.parentFile, recursive = false).map { it.name }
+		assertTrue("listing should include the created file", listed.contains("Main.kt"))
 
-        // Step 4: Verify file service can read created file
-        val readResult = fileService.readFile("app/src/main/kotlin/com/example/Main.kt")
-        assertTrue("Failed to read created file: ${readResult.error}", readResult.success)
-        assertTrue("File content mismatch", readResult.data!!.contains("package com.example"))
+		assertTrue("delete should succeed", resolved.delete(sourceFile))
+		assertFalse("deleted file should be gone", sourceFile.exists())
+	}
 
-        // Step 5: Cleanup via FileService
-        val deleteResult = fileService.deleteFile("app/src/main/kotlin/com/example/Main.kt")
-        assertTrue("Failed to delete file: ${deleteResult.error}", deleteResult.success)
-    }
+	// Canonical, component-wise containment: rejects sibling-prefix and traversal escapes that a
+	// naive absolutePath.startsWith() would wrongly accept.
+	private fun File.isWithin(root: File) = canonicalFile.toPath().startsWith(root.canonicalFile.toPath())
 }