ADFA-3771: Document android-sdk.zip image recompression procedure - #1602
Conversation
Recompressed the two oversized default_wallpaper.png files in the downloaded android-sdk.zip with pngquant (~66% combined size reduction, no visible quality loss) and wrote up the repeatable procedure so future oversized-asset findings don't require rediscovering the snap-confinement workaround or the in-place zip-entry-replacement trick. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough
WalkthroughThe Android SDK image recompression documentation clarifies pngquant snap confinement, generalizes platform directory paths, adjusts in-place zip replacement commands, and verifies both arm64 and armeabi-v7a archives with ChangesAndroid SDK image documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/process/recompress-android-sdk-images.md`:
- Around line 12-14: Update every fenced shell block in the document, including
the blocks around the shown command and the referenced sections, to use a sh or
shell language identifier on each opening fence while leaving the commands
unchanged.
- Around line 53-59: Update the verification procedure for the Android SDK
archives to run an equivalent unzip -t integrity check on
android-sdk-armeabi-v7a.zip, alongside the existing check for
android-sdk-arm64-v8a.zip, after both replacements are completed.
- Line 50: Update the zip command in the recompression instructions to reference
the archive from the parent directory after changing into work, using the
correct sibling path while preserving the existing wallpaper input.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7bcb1302-3dd7-4e12-9ac2-2e465ceeb205
📒 Files selected for processing (1)
docs/process/recompress-android-sdk-images.md
Review feedback on PR #1602 -- bare triple-backtick fences don't get shell syntax highlighting or get picked up as shell snippets by doc tooling that keys off the language tag. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Review feedback on PR #1602 -- the command referenced assets/ relative to the directory before cd work, which resolves to the nonexistent work/assets/ instead of the sibling assets/ directory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Review feedback on PR #1602 -- the verification step only checked android-sdk-arm64-v8a.zip even though the same section says to repeat the update for android-sdk-armeabi-v7a.zip, so a bad update to the armv7 zip would go undetected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…path Inline the snap-confinement explanation instead of pointing at a personal Claude Code memory note nobody else can resolve. Replace the hardcoded android-36 example path with an android-<N> placeholder and a note to substitute the actual platform directory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
We need to revert this. The markdown file contains at least one error. And it doesn't belong here, it should be over in the dev-assets git repo |
Summary
default_wallpaper.pngatdrawable-sw600dp-nodpianddrawable-sw720dp-nodpi, 2.75MB and 3.94MB) bundled inside the downloadedandroid-sdk.zip.pngquant(lossy palette quantization) — 69% and 64% smaller respectively, ~4.4MB combined savings per architecture zip, no visible quality loss.android-sdk-arm64-v8a.zip/android-sdk-armeabi-v7a.zipare downloaded assets (seedebugAssetsinapp/build.gradle.kts), not built in this repo, so there's no app code to change here — this PR documents the repeatable procedure (including a snap-confinement gotcha withpngquantand the in-place zip-entry-replacement trick) so future oversized-asset findings don't require rediscovering it.android-sdk.zipon appdevforall.org is a separate step outside this repo, not covered by this PR.Test plan
unzip -ton both locally-updated zips reports no errorsspotlessCheckpasses (docs-only change)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com