ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box

[Elissa-AppDevforAll]

Also changed "Proceed" to "Yes" and "Cancel" to "No" because those are the answers to the question being asked.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5906685-bf08-4d46-9934-93f24fe10665

📥 Commits

Reviewing files that changed from the base of the PR and between 263c85b and 88f0f69.

📒 Files selected for processing (1)

• resources/src/main/res/values/strings.xml

🚧 Files skipped from review as they are similar to previous changes (1)

• resources/src/main/res/values/strings.xml

---

📝 Walkthrough

• Updated the “Open External Link” consent dialog text capitalization/punctuation (e.g., “Open External Link?” → “Open external link?”).
• Updated the “don’t ask again” text to use consistent capitalization (“Don’t ask again”).
• Reverted consent dialog button labels back to “Proceed” and “Cancel”.
• Risks/best-practice notes: Low—strings-only UI label changes with no behavioral logic changes indicated.

Walkthrough

The URL consent dialog title and “Don’t ask again” label capitalization were updated. The consent message and “Cancel”/“Proceed” button labels remain unchanged.

Changes

URL consent dialog

Layer / File(s)	Summary
Update consent dialog labels resources/src/main/res/values/strings.xml	Updates title and repeat-prompt capitalization while preserving the consent message and button labels.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: hal-eisen-adfa

Poem

A rabbit hops through strings so neat,
The title’s case is soft and sweet.
“Don’t ask again” now rests in place,
While buttons keep their former face.
The consent words remain complete.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the capitalization cleanup in the external link dialog.
Description check	✅ Passed	The description is related to the same dialog and its button labels, so it is not off-topic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 1218: Restore the warning dialog’s cancel label without changing its
intended “Cancel” action: update the url_consent_cancel resource used by
MainActivity, or switch that dialog to an existing generic cancel resource,
while preserving the URL-consent dialog’s separate negative label as “No”.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 581690d1-23bd-4a0f-b0e9-be7199d8037c

📥 Commits

Reviewing files that changed from the base of the PR and between 8077407 and 263c85b.

📒 Files selected for processing (1)

• resources/src/main/res/values/strings.xml