Converts search to new Pagefinder - #563
Open
BoDonkey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please indicate which branch this PR should merge into:
Check one
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR updates the doc search to use the Pagefinder package. This was needed to support the marketing site unified search results. Rather than maintaining two packages (the old search and the new Pagefinder) the docs search was converted. Closes PRO-9750
What are the specific steps to test this change?
Full details:
SEARCH.mdat the repo root.rm -rf node_modules package-lock.json && npm install(arollupversion pin was added —a clean install picks it up; see
README.mdif you hit aswagger-ui-distbuild error)npm run build(this also builds the Pagefind index —build:search-indexrunsautomatically as part of
build)npm run previewcorrect, not a bug
npm run dev/vitepress dev— the box will say "Search isunavailable right now." That's expected; the index is a build artifact.
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: