Skip to content

test: add Portal mutation smoke - #6

Merged
nobodyiam merged 2 commits into
mainfrom
codex/apollo-cli-mutation-smoke-5669
Aug 30, 2026
Merged

nobodyiam merged 2 commits into
mainfrom
codex/apollo-cli-mutation-smoke-5669

Conversation

@nobodyiam

Copy link
Copy Markdown
Member

Summary

  • add a manually dispatched and weekly mutation smoke workflow that builds a pinned Apollo revision with disposable Portal, ConfigService, AdminService, and H2 databases
  • pin and checksum the Apollo OpenAPI specification used during the assembly build, wait for Portal internal AdminService discovery, and isolate CLI state with APOLLO_CLI_HOME
  • create disposable user-token scopes and unique app data, then verify confirmation and permission failures, config add/update/target-only/no-op behavior, release creation/listing, rollback, and actual server state
  • redact config set response values and scan CLI results plus Apollo logs so credentials and generated config values never appear in diagnostics
  • document the local command and required release-gate workflow in both READMEs

Testing

  • cargo fmt --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --locked (179 tests passed)
  • bash -n scripts/mutation-smoke.sh
  • YAML parse for both GitHub Actions workflows
  • git diff --check
  • full pinned Apollo Portal + H2 smoke: config add/update/no-op and target-only preservation, missing --yes, read-only permission denial, two releases, rollback, server-state verification, and secret scan all passed

Refs apolloconfig/apollo#5669

Add a pinned Apollo Portal and H2 mutation workflow covering config merge, confirmation and permission failures, release creation, and rollback. Isolate CLI state and redact mutation response values so smoke diagnostics remain secret-safe.\n\nRefs apolloconfig/apollo#5669
Copilot AI lite review requested due to automatic review settings August 30, 2026 12:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T12:57:45.018824Z 8e7b0df New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: adb85530-1e7e-4dff-bf81-dcef21276463


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f94391ee6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/mutation-smoke.sh

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repeatable “real Apollo Portal” mutation smoke test path for apollo-cli, including CI automation, improved state isolation, and stronger redaction guarantees for config mutation outputs.

Changes:

  • Add a new scripts/mutation-smoke.sh end-to-end smoke that builds a pinned Apollo revision, runs Portal+H2, and validates config/apply/release/rollback behavior against live server state with redacted diagnostics.
  • Introduce APOLLO_CLI_HOME to isolate CLI state (config + file-backed credentials) for CI/smoke runs, and document the behavior in both READMEs.
  • Ensure config mutation outputs redact item values in JSON output (and update OpenAPI integration tests accordingly), plus add a scheduled/manual GitHub Actions workflow to run the smoke.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/openapi.rs Updates integration assertions to require redacted config values and to ensure plaintext values don’t appear in stdout.
src/config.rs Adds APOLLO_CLI_HOME override to place config.toml under an isolated absolute directory (with tests).
src/command.rs Redacts config item values in rendered mutation/list responses by injecting sanitized data into output rendering.
scripts/mutation-smoke.sh New pinned-revision Portal+H2 mutation smoke script with state assertions and log/CLI output redaction checks.
README.md Documents APOLLO_CLI_HOME and the new mutation smoke + release-gate expectations.
README.zh.md Same documentation updates as README.md for Chinese readers.
.github/workflows/mutation-smoke.yml New scheduled + manual workflow to run the mutation smoke on Ubuntu with JDK 17 + stable Rust.
.github/workflows/ci.yml Adds a bash -n scripts/mutation-smoke.sh syntax check step.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated
Comment thread README.zh.md Outdated
@nobodyiam
nobodyiam merged commit 77246e4 into main Aug 30, 2026
3 checks passed
@nobodyiam
nobodyiam deleted the codex/apollo-cli-mutation-smoke-5669 branch August 30, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants