ci: Drop cross-repo model regeneration dispatch to apify-client-python - #2835
Merged
Conversation
vdusek
added
adhoc
Contributor
|
🗑️ Preview for this PR was deleted. |
vdusek
force-pushed
the
ci/drop-client-model-dispatch
branch
from
August 3, 2026 11:58
32ae39c to
e491c9d
Compare
TC-MO
approved these changes
Aug 3, 2026
TC-MO
left a comment
TC-MO
left a comment
Contributor
There was a problem hiding this comment.
LGTM, so no longer companions PR's and no longer thinking about stacking merges so everything generates correctly :D?
Contributor
Author
Yes, because of these and other issues, we rethought this. There will be only nightly syncs from now, let's see how that will work. |
vdusek
added a commit
to apify/apify-client-python
that referenced
this pull request
Aug 3, 2026
) Replaces the apify-docs-triggered model regeneration with a nightly job, and records which published OpenAPI specification the generated models came from. ## What changes - **`on_schedule_regenerate_models.yaml`** - nightly at 02:00 UTC plus manual dispatch. Regenerates on master and opens a pull request when the models change. `manual_regenerate_models.yaml` is deleted. - **`scripts/openapi_spec.py`** - downloads and validates the published specification into git-ignored `tmp/` (both codegen passes read that one copy), then records its `info.version` in `pyproject.toml` under `[tool.apify.openapi-spec]`. The specification itself is not committed. - **`_models.py`** loses the `Plan.available_proxy_groups` docstring - accumulated codegen drift from the `datamodel-code-generator` bumps (#968, #975), not a specification change. ## Why The old workflow was dispatched by apify-docs and checked out a permanent, never-rebased branch *before* regenerating, so it generated with that branch's stale tooling. In #979 that produced `_literals.py` in the pre-#941 closed `Literal[...]` form; merging it would have silently reverted the enum relaxation. It also opened with a `TODO` title that blocked `pr-title-check` - a design that needs human action to become mergeable, which is what let #979 rot for 20 days while the same spec changes were landed by hand (#923, #936, #947, #960, #974). The nightly job always generates on master and rebuilds its `ci/regenerate-models` branch from master instead of appending, so the diff is always "current spec vs current master" and can't resurrect a stale generated file. It opens with a mergeable `chore:` title; reviewers retitle to `fix:`/`feat:` when the diff is user-facing. ## Notes - **Merge apify/apify-docs#2835 first** - it removes the dispatch that still calls the workflow deleted here. - **Needs a `SLACK_WEBHOOK_URL` repository secret** for the failure alert. - The recorded version is a coarse marker, not a content identity: apify-docs bumps `components/version.yaml` in a follow-up `[skip ci]` commit, so a deploy can publish new content under the old stamp. A moved value proves the specification changed; an unchanged one proves nothing. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the cross-repo dispatch that opened a companion model-regeneration PR in
apify-client-pythonfor every spec-changing docs PR, and rewrites theAGENTS.mdsection describing it.apify-client-pythonnow pulls the spec on its own nightly schedule instead, so nothing on this side needs to push to it or be merged in lockstep with a client PR.Why the dispatch goes away:
TODOtitle that a human had to replace before it could be merged, so unmerged PRs and their stale branches piled up.Also drops what only the removed jobs needed: the
closedpull request trigger, theif:guard skipping lint on close events, and thepull-requests: readpermission.Merge this before apify/apify-client-python#983 - that PR deletes
manual_regenerate_models.yaml, which the dispatch removed here still calls.✍️ Drafted by Claude Code