Repository navigation
fix: extend the request timeout by wait_for_finish in start() and build() - #1225
Merged
Merged
Conversation
vdusek
marked this pull request as ready for review
November 11, 2026 13:08
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — max-lines |
| Review findings | ✅ none |
| Reviewer escalation | ❌ The change alters the per-request timeouts (and so the retry timing) of start(), build(), default_build() and task start(), which is runtime configuration that a maintainer should confirm. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
max-lines: 277 changed lines (+251/-26), limit 200
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 6269d12cc · workflow run
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
- Coverage 95.74% 95.71% -0.04%
==========================================
Files 63 63
Lines 6658 6669 +11
==========================================
+ Hits 6375 6383 +8
- Misses 283 286 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Mantisus
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActorClient.start(),ActorClient.build(),ActorClient.default_build()andTaskClient.start()(and their async twins) sendwaitForFinish, but their request timeout was the plain tier (30 s, or 5 s fordefault_build()). The API holds the response for up to 60 s, so with a longerwait_for_finishthe first attempt timed out and the client retried. For a POST this started a second run or build.When
timeoutis a tier, these methods now addwait_for_finish(capped at 60 s) to it, as the JS client does intimeoutForWaitForFinish. An explicittimedeltaand'no_timeout'are used as given.Closes: #1132
✍️ Drafted by Claude Code