Repository navigation
test: use the run's own token in the metamorph integration test - #1220
Conversation
… not allowed anymore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
- Coverage 95.76% 95.74% -0.02%
==========================================
Files 63 63
Lines 6676 6674 -2
==========================================
- Hits 6393 6390 -3
- Misses 283 284 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — no-risky-content |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
no-risky-content: tests/_utils.py: environment variable access (env-access); tests/integration/test_run.py: environment variable access (env-access)
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed b2df23f71 · workflow run
vdusek
left a comment
There was a problem hiding this comment.
Thanks @mvolfik. Did you open the PR manually or via agent?
I renamed it to the "test" type, since the change touches only tests, not the source code (we don't want this in changelog).
I'm asking because our CLAUDE.md links to the commit conventions, so I'm curios whether your agent ignores it for some reason or not, because you opened it manually (if you wrote the title yourself, then it's ok).
|
nope, it was done manually :) fair point, in apify-core, the commit conventions are a bit of a wild west (mostly because we don't have to care about semver that much), thanks for fixing it |
vdusek
left a comment
There was a problem hiding this comment.
A few things worth considering
fix for breaking change from apify/apify-core#32513