Skip to content

fix: Add missing parent_request_id to server().request method - #1214

Merged
vdusek merged 3 commits into
masterfrom
composition-actor-request-id
Nov 11, 2026
Merged

vdusek merged 3 commits into
masterfrom
composition-actor-request-id

Conversation

@janbuchar

Copy link
Copy Markdown
Contributor

@janbuchar
janbuchar requested a review from szaganek as a code owner November 9, 2026 15:24
@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 9, 2026
@janbuchar
janbuchar requested review from Pijukatel and vdusek November 9, 2026 15:24
@janbuchar janbuchar self-assigned this Nov 9, 2026
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 9, 2026
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (e521a24) to head (1ddfd09).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   95.73%   95.75%   +0.02%     
==========================================
  Files          63       63              
  Lines        6676     6672       -4     
==========================================
- Hits         6391     6389       -2     
+ Misses        285      283       -2     
Flag Coverage Δ
integration 90.96% <80.00%> (+0.08%) ⬆️
unit 91.30% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pijukatel Pijukatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestions.

Comment thread docs/02_concepts/14_server_actors.mdx Resolved

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chore - no changelog mention?

Comment thread docs/02_concepts/14_server_actors.mdx Resolved
Comment thread tests/unit/test_actor_server.py Resolved
@janbuchar janbuchar changed the title chore: Add parentRequestId to server().request method feat: Add parent_request_id to server().request method Nov 10, 2026
@janbuchar janbuchar changed the title feat: Add parent_request_id to server().request method fix: Add missing parent_request_id to server().request method Nov 11, 2026
@vdusek vdusek changed the title fix: Add missing parent_request_id to server().request method fix: Add missing parent_request_id to server().request method Nov 11, 2026

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, last 2 nits (optional), otherwise LGTM, thanks 🚀.

Comment thread src/apify_client/_utils/http.py Resolved
@vdusek

vdusek commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

merging as we want to release this

@vdusek
vdusek merged commit 3c41109 into master Nov 11, 2026
35 of 36 checks passed
@vdusek
vdusek deleted the composition-actor-request-id branch November 11, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants