Skip to content

WICKET-7191 Apply tag attribute "required" when a component is set to required #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitstorm wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −3
Open

WICKET-7191 Apply tag attribute "required" when a component is set to required #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...core-tests/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage_expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
</script>
</head><body>
<form wicket:id="form" id="form1" method="post" action="./page?0-1.-form"><div id="form1_hf_0" hidden="" class="hidden-fields"></div>
<input type="text" wicket:id="txt1" value="foo" name="txt1"/>
<input type="text" wicket:id="txt2" value="bar" name="txt2"/>
<input type="text" wicket:id="txt1" value="foo" name="txt1" required="required"/>
<input type="text" wicket:id="txt2" value="bar" name="txt2" required="required"/>
<input type="submit" value="Submit" wicket:id="submit" name="p::submit" id="submit2"/>
</form>
</body>
Expand Down
2 changes: 1 addition & 1 deletion ...src/test/java/org/apache/wicket/markup/html/form/validation/HomePage1_ExpectedResult.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<form wicket:id="form" id="form9" method="post" action="./org.apache.wicket.markup.html.form.validation.HomePage1?1-1.-bug-form"><div id="form9_hf_0" hidden="" class="hidden-fields"></div>
<div wicket:id="border"><wicket:border>
<wicket:body>
<input wicket:id="name" value="" name="border:border_body:name"/>
<input wicket:id="name" value="" name="border:border_body:name" required="required"/>
<div wicket:id="feedback"><wicket:panel>

</wicket:panel></div>
Expand Down
18 changes: 18 additions & 0 deletions wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,11 @@ protected void onComponentTag(final ComponentTag tag)
onDisabled(tag);
}

if (isRequired())
{
onRequired(tag);
}

super.onComponentTag(tag);
}

Expand All @@ -1424,6 +1429,19 @@ protected void onDetach()
convertedInput = null;
}

/**
* Called by {@link #onComponentTag(ComponentTag)} when the component is required. By default,
* this method will add a required="required" attribute to the tag. Components may override this
* method to tweak the tag as they think is fit.
*
* @param tag
* the tag that is being rendered
*/
protected void onRequired(final ComponentTag tag)
{
tag.put("required", "required");
}

/**
* Called by {@link #onComponentTag(ComponentTag)} when the component is disabled. By default,
* this method will add a disabled="disabled" attribute to the tag. Components may override this
Expand Down
Loading