UNOMI-977: Restrict router import/export configuration to system administrators - #853
Open
sergehuber wants to merge 1 commit into
Open
UNOMI-977: Restrict router import/export configuration to system administrators#853sergehuber wants to merge 1 commit into
sergehuber wants to merge 1 commit into
Conversation
…nistrators A router import or export configuration carries a Camel source or destination URI, so writing one reaches the filesystem and remote endpoints. That is a host-level capability rather than one confined to a tenant's own data, and it should require the corresponding role. ImportConfigurationServiceEndPoint and ExportConfigurationServiceEndPoint now require UnomiRoles.ADMINISTRATOR, on the oneshot and multipart upload paths as well as the CRUD ones. RouterEndpointRoleSecurityIT exercises all four over HTTP rather than inspecting the annotations. A role annotation that is present but not wired - an endpoint outside the security filter's scope, say - would still satisfy a unit test that only reads the annotation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Closed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A router import or export configuration carries a Camel source or destination URI, so writing one
reaches the filesystem and remote endpoints. That is a host-level capability rather than one
confined to a tenant's own data, and it should require the corresponding role.
ImportConfigurationServiceEndPoint and ExportConfigurationServiceEndPoint now require
UnomiRoles.ADMINISTRATOR, on the oneshot and multipart upload paths as well as the CRUD ones.
RouterEndpointRoleSecurityIT exercises all four over HTTP rather than inspecting the annotations. A
role annotation that is present but not wired - an endpoint outside the security filter's scope, say
Jira: https://issues.apache.org/jira/browse/UNOMI-977