Skip to content

Require authentication for GraphQL WebSocket upgrade (unomi-2.7.x) - #845

Closed
sergehuber wants to merge 1 commit into
unomi-2.7.xfrom
backport/graphql-websocket-auth-2.7.x
Closed

Require authentication for GraphQL WebSocket upgrade (unomi-2.7.x)#845
sergehuber wants to merge 1 commit into
unomi-2.7.xfrom
backport/graphql-websocket-auth-2.7.x

Conversation

@sergehuber

Copy link
Copy Markdown
Contributor

Summary

  • Require Basic (JAAS) authentication before accepting a GraphQL WebSocket upgrade on unomi-2.7.x.
  • Backport of Require authentication for GraphQL WebSocket upgrade (master) #843, adapted for the maintenance-line GraphQL auth model (JAAS only).
  • Existing WebSocket IT now sends credentials; adds coverage for missing/wrong auth returning 401.

Test plan

  • GraphQL WebSocket IT on this branch
  • Manual: unauthenticated upgrade returns 401; Basic auth succeeds

Validate credentials before accepting the GraphQL WebSocket upgrade,
attach the authenticated subject to the subscription socket, and clear
context after subscribe. Add unit and integration coverage.
@sergehuber sergehuber changed the title Require authentication for GraphQL WebSocket upgrade Require authentication for GraphQL WebSocket upgrade (unomi-2.7.x) Aug 7, 2026
@sergehuber

Copy link
Copy Markdown
Contributor Author

Closing this one: the team is not targeting the 2.7.x line with this work at the moment, so it should not sit open implying it is queued.

This is a scheduling decision and nothing to do with the change itself. The equivalent changes for master (#843) and 3.0.x (#844) remain open. The backport/graphql-websocket-auth-2.7.x branch is kept, so this can be reopened as-is if 2.7.x maintenance picks up again.

@sergehuber sergehuber closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants