Repository navigation
[Fix][Relax] Preserve PyTorch grid_sample grid layout - #20986
Open
DiadkoShmek wants to merge 1 commit into
Open
DiadkoShmek wants to merge 1 commit into
DiadkoShmek wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20882.
PyTorch exports the grid in
[N, H_out, W_out, 2]order. Withlayout="NCHW", Relax reads it as[N, 2, H_out, W_out]. Passing it through directly makes the output shape(1, 1, 5, 2)for a grid whose expected output is(1, 1, 3, 5). A2×2grid happens to yield the expected shape but can still sample the wrong coordinates.Move the coordinate axis before emitting the Relax operator. Use a non-square grid in the IR test and compare compiled LLVM results against PyTorch eager for both grid shapes.
Local validation on
23a6dbe, Linux x86-64, PyTorch 2.10.0, and LLVM from TIRx 0.1.0.grid_sampleand adjacentaffine_gridsubset passes 5 tests. Both end-to-end outputs match PyTorch eager.Codex assisted with the patch and regression tests.