Count HTTP/2 clients in IP connection metrics - #13582
Open
bneradt wants to merge 1 commit into
Open
Conversation
The IPv4 and IPv6 client connection metrics only count HTTP/1 sessions, so deployments using HTTP/2 report fewer accepted connections than Traffic Server actually handles. This patch moves address-family accounting into the shared proxy session and applies it to every supported HTTP protocol. It also adds replay coverage and updates the existing mixed-protocol metric expectation. Fixes: apache#12105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPv4 and IPv6 client connection metrics only count HTTP/1 sessions,
so deployments using HTTP/2 report fewer accepted connections than
Traffic Server actually handles.
This patch moves address-family accounting into the shared proxy session
and applies it to every supported HTTP protocol. It also adds replay
coverage and updates the existing mixed-protocol metric expectation.
Fixes: #12105