Fix silently dropped Streams.all autest assertions - #13577
Open
bneradt wants to merge 1 commit into
Open
Conversation
AuTest's Streams entity defines All, not all, and does not override __setattr__, so every `Streams.all = ...` assignment created a dead instance attribute rather than registering a tester. Twelve assertions across seven gold tests had never run, and two of the expectations behind them had rotted unnoticed as a result. This patch renames those assignments to Streams.All so the assertions register, and corrects the two expectations they exposed: a gold file that opened with three backticks rather than the two that mark an AuTest wildcard, and a test that left outbound server verification at the default ENFORCED while its origin serves a self-signed certificate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bneradt
force-pushed
the
claude/fix-dead-streams-all-assertions
branch
from
August 20, 2026 17:44
c0213cf to
1c4ccdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuTest's
Streamsentity definesAll, notall, and does not override__setattr__, so everyStreams.all = ...assignment created a dead instance attribute rather than registering a tester. Twelve assertions across seven gold tests had never run, and two of the expectations behind them had rotted unnoticed as a result.This renames those assignments to
Streams.Allso the assertions register, and corrects the two expectations they exposed:client_default_inactivity_timeout.goldopened with three backticks rather than the two that mark an AuTest wildcard, andtls_hooks_client_verifyleftproxy.config.ssl.client.verify.server.policyat the defaultENFORCEDwhile its origin serves a self-signed cert.cert_update.test.pyhas two more of these, left alone because #13576 is already rewriting that file.