Skip to content

fix(i18n): review Traditional Chinese count labels - #43063

Open
nrps9909 wants to merge 1 commit into
apache:masterfrom
nrps9909:codex/review-zhtw-fuzzy-counts
Open

fix(i18n): review Traditional Chinese count labels#43063
nrps9909 wants to merge 1 commit into
apache:masterfrom
nrps9909:codex/review-zhtw-fuzzy-counts

Conversation

@nrps9909

Copy link
Copy Markdown

SUMMARY

Review and confirm 23 fuzzy Traditional Chinese (zh_TW) messages whose existing matches were objectively incorrect, and align one adjacent confirmed column-count label.

This focuses on dynamic count, selection, and elapsed-time UI text:

  • restores dropped %s placeholders in imported, metric, selection, and time labels;
  • corrects mismatched units and fixed values such as 10 seconds, 12 hours, 24 hours, and percentile presets;
  • distinguishes Taiwan Traditional Chinese column/row terminology (欄位 / );
  • removes the fuzzy flag only after checking each message against its frontend call site.

Open-PR overlap check: draft #38266 also mechanically refreshes this catalog as part of a repository-wide Babel update. Six target msgids occur there as generated fuzzy guesses; its substantive database forbidden-access translation is unrelated and is not touched by this PR.

This contribution was prepared with Codex assistance. I reviewed the source call sites, translations, placeholders, diff, and validation results, and I will respond to review feedback.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No screenshot: this is a locale-catalog-only change across several dynamic UI states. Representative corrections include:

  • 數據集已導入已匯入 %s
  • %s 分鐘前
  • 自定義列已選取 %s/%s 個欄位
  • 9/91 百分位10/90 百分位數 and 5/95 百分位數

TESTING INSTRUCTIONS

  • msgfmt --check --check-format -o /dev/null superset/translations/zh_TW/LC_MESSAGES/messages.po
  • Targeted Babel compile for all 24 changed messages: 24/24 translated, no placeholder errors
  • python scripts/translations/check_translation_regression.py --compare <baseline>: no translation regressions; zh_TW confirmed translations +23, fuzzy translations -23
  • pre-commit run: passed for the staged catalog
  • Verified all 24 changed entries against their source call sites and confirmed zero remaining fuzzy flags in the reviewed set

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review

bito-code-review Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #c68f09

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: da729fe..da729fe
    • superset/translations/zh_TW/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.54%. Comparing base (47adbe3) to head (da729fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #43063      +/-   ##
==========================================
- Coverage   66.55%   66.54%   -0.01%     
==========================================
  Files        2864     2864              
  Lines      161894   161894              
  Branches    37305    37305              
==========================================
- Hits       107742   107739       -3     
- Misses      52106    52108       +2     
- Partials     2046     2047       +1     
Flag Coverage Δ
hive 38.15% <ø> (ø)
mysql 57.68% <ø> (ø)
postgres 57.73% <ø> (-0.01%) ⬇️
presto 40.11% <ø> (ø)
python 59.11% <ø> (-0.01%) ⬇️
sqlite 57.35% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:traditional-chinese i18n Namespace | Anything related to localization size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant