chore(lint): scope in-repo eslint plugins under @superset-ui by KHARSHAVARDHAN-eng · Pull Request #43054 · apache/superset

KHARSHAVARDHAN-eng · 2026-08-11T07:51:29Z

SUMMARY

Namespaces in-repo ESLint plugins (eslint-plugin-i18n-strings, eslint-plugin-icons, eslint-plugin-theme-colors) under the @superset-ui scope to prevent npm registry name shadowing and phantom security audit flags.

Fixes #42982

TESTING INSTRUCTIONS

Run npm run lint and npm run lint-stats.

ADDITIONAL INFORMATION

Has associated issue: chore(lint): scope in-repo eslint plugins so they cannot be shadowed by public names #42982

…ReportList tests

bito-code-review · 2026-08-11T07:51:45Z

Code Review Agent Run #d12871

Actionable Suggestions - 0

Review Details

Files reviewed - 5 · Commit Range: a87141d..4b45c0b
- scripts/check-type.js
- superset-frontend/eslint-rules/eslint-plugin-i18n-strings/index.ts
- superset-frontend/eslint.config.minimal.js
- superset-frontend/src/pages/AlertReportList/AlertReportList.test.tsx
- superset-frontend/src/pages/AlertReportList/index.tsx
Files skipped - 5
- superset-frontend/eslint-rules/eslint-plugin-i18n-strings/package.json - Reason: Filter setting
- superset-frontend/eslint-rules/eslint-plugin-icons/package.json - Reason: Filter setting
- superset-frontend/eslint-rules/eslint-plugin-theme-colors/package.json - Reason: Filter setting
- superset-frontend/package-lock.json - Reason: Filter setting
- superset-frontend/package.json - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-08-11T08:12:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.61%. Comparing base (5ee2793) to head (925d6cf).
⚠️ Report is 64 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #43054      +/-   ##
==========================================
+ Coverage   66.55%   66.61%   +0.05%     
==========================================
  Files        2864     2866       +2     
  Lines      161894   162682     +788     
  Branches    37305    37466     +161     
==========================================
+ Hits       107748   108364     +616     
- Misses      52100    52219     +119     
- Partials     2046     2099      +53

Flag	Coverage Δ
hive	`38.20% <ø> (+0.04%)`	⬆️
javascript	`73.64% <100.00%> (+<0.01%)`	⬆️
mysql	`57.88% <ø> (+0.20%)`	⬆️
postgres	`57.91% <ø> (+0.17%)`	⬆️
presto	`40.15% <ø> (+0.03%)`	⬆️
python	`59.30% <ø> (+0.17%)`	⬆️
sqlite	`57.55% <ø> (+0.18%)`	⬆️
unit	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rusackas · 2026-08-13T01:50:27Z

Maybe @hainenber would want to take a look at this one?

hainenber · 2026-08-13T03:16:15Z

            fix(fixer) {
-              const source = context.getSourceCode().getText(prop.value);
+              const sourceCode = context.sourceCode || context.getSourceCode();
+              const source = sourceCode.getText(prop.value);


Do you have a rationale for this change? Isnt the PR supposed for scope limitstion of running custom lint rules?

hainenber · 2026-08-13T03:17:18Z

 }));

+// Mock withToasts HOC to inject default toast functions while preserving explicit test spies passed via props
+jest.mock('src/components/MessageToasts/withToasts', () => ({


What are these changes in the test files?

…n ordering - Cast merged withToasts mock props to the generic prop type P before spreading onto Component, fixing a TS2322 error in AlertReportList.test.tsx (npm run type). - Reorder the newly added @superset-ui/eslint-plugin-* devDependencies alphabetically in package.json to satisfy oxfmt (pre-commit). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

netlify · 2026-08-13T03:31:19Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`925d6cf`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a7d39ef76b3290008a79ed5
😎 Deploy Preview	https://deploy-preview-43054--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

KHARSHAVARDHAN-eng added 4 commits August 11, 2026 13:18

fix(i18n): localize alert and report execution toast messages

a87141d

test: mock withToasts passthrough in AlertReportList tests

84f4840

test(alerts): update withToasts mock and add i18n assertions in Alert…

2515715

…ReportList tests

chore(lint): scope in-repo eslint plugins under @superset-ui

4b45c0b

KHARSHAVARDHAN-eng requested review from betodealmeida, dpgaspar, eschutho, geido, hainenber, kgabryje, mistercrunch, nytai, rusackas, sadpandajoe, sha174n and villebro as code owners August 11, 2026 07:51

pull-request-size Bot added the size/L label Aug 11, 2026

dosubot Bot added the dependencies:npm label Aug 11, 2026

github-actions Bot added the risk:ci-script PR modifies scripts that execute in CI (supply chain risk) label Aug 11, 2026

hainenber reviewed Aug 13, 2026

View reviewed changes

Navigation Menu

Uh oh!

chore(lint): scope in-repo eslint plugins under @superset-ui - #43054

chore(lint): scope in-repo eslint plugins under @superset-ui#43054
KHARSHAVARDHAN-eng wants to merge 5 commits into
apache:masterfrom
KHARSHAVARDHAN-eng:chore/scope-in-repo-eslint-plugins

KHARSHAVARDHAN-eng commented Aug 11, 2026

Uh oh!

bito-code-review Bot commented Aug 11, 2026 •

edited

Loading

Code Review Agent Run #d12871

Uh oh!

codecov Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

rusackas commented Aug 13, 2026

Uh oh!

hainenber Aug 13, 2026

Uh oh!

hainenber Aug 13, 2026

Uh oh!

netlify Bot commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KHARSHAVARDHAN-eng commented Aug 11, 2026

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #d12871

Uh oh!

codecov Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rusackas commented Aug 13, 2026

Uh oh!

hainenber Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

hainenber Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

netlify Bot commented Aug 13, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bito-code-review Bot commented Aug 11, 2026 •

edited

Loading

codecov Bot commented Aug 11, 2026 •

edited

Loading