WW-5706 Align RestfulActionMapper action name handling with DefaultActionMapper - #1880
Draft
lukaszlenart wants to merge 1 commit into
Draft
WW-5706 Align RestfulActionMapper action name handling with DefaultActionMapper#1880lukaszlenart wants to merge 1 commit into
lukaszlenart wants to merge 1 commit into
Conversation
…h DefaultActionMapper RestfulActionMapper derived the action name straight from the request URI, unlike DefaultActionMapper which validates it via cleanupActionName against the allowedActionNames pattern. Apply the same check (and the struts.allowed.action.names / struts.default.action.name settings) so both mappers handle action names consistently. Fixes: https://issues.apache.org/jira/browse/WW-5706 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016XMyQ1CRuYZkqygmD4aGHv
|
lukaszlenart
marked this pull request as draft
August 30, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RestfulActionMapperderived the action name directly from the request URI, whereasDefaultActionMappernormalizes and validates it throughcleanupActionNameagainst theallowedActionNamespattern. This change applies the same validation inRestfulActionMapper(honouring thestruts.allowed.action.namesandstruts.default.action.namesettings) so both mappers handle action names consistently. When the extracted name does not match the allowed pattern, the configured default action name is used and a warning is logged.Restful2ActionMapperalready extendsDefaultActionMapperand inherits this behaviour, so no change is needed there.Added regression tests covering both a rejected and an accepted action name.
Fixes WW-5706
🤖 Generated with Claude Code