Honour ignoreOutsideDomain when set on its own in HostURLFilter - #2074
Open
rzo1 wants to merge 1 commit into
Open
Honour ignoreOutsideDomain when set on its own in HostURLFilter#2074rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
HostURLFilter.configure() read the ignoreOutsideDomain parameter but tested the ignoreOutsideHost node for null. A configuration naming only ignoreOutsideDomain was therefore discarded and the filter let every URL through, while one naming only ignoreOutsideHost failed with a NullPointerException while the topology was starting. Now each parameter is tested independently. Topologies which set only ignoreOutsideDomain start restricting the crawl to the source domain, as configured.
rzo1
force-pushed
the
fix/hosturlfilter-domain-config
branch
from
August 27, 2026 12:50
47f3163 to
30135b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostURLFilter.configure()read theignoreOutsideDomainparameter but tested theignoreOutsideHostnode for null. A configuration naming onlyignoreOutsideDomainwas silently discarded and the filter let every URL through; one naming onlyignoreOutsideHostthrew aNullPointerExceptionat topology startup. Each parameter is now tested on its own.Topologies setting only
ignoreOutsideDomainwill start restricting outlinks to the source domain, as configured. Configurations setting both keys, including all three archetypes, are unaffected.For all changes
Is there a issue associated with this PR? Is it referenced in the commit message? - no issue
Does your PR title start with
#XXXXwhereXXXXis the issue number you are trying to resolve? - no issueHas your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
Is the code properly formatted with
mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?For code changes
mvn clean verify? -coremodule tests only (348 run, all green)HostURLFilterTest, both fail without the fix