Skip to content

[SPARK-59261][SQL] Memoize outputPartitioning on the projection and SPJ grouping nodes #58542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peter-toth wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −4
Open

[SPARK-59261][SQL] Memoize outputPartitioning on the projection and SPJ grouping nodes #58542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/AliasAwareOutputExpression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@ import org.apache.spark.sql.catalyst.trees.MultiTransform
*/
trait PartitioningPreservingUnaryExecNode extends UnaryExecNode
with AliasAwareOutputExpression {
final override def outputPartitioning: Partitioning = {
// A `lazy val` because the planner asks a node for its partitioning many times, and this body
// projects every partitioning expression through the output aliases, and for a
// `KeyedPartitioning` child also builds an `ExpressionSet` per key position and cross-products
// the per-position alternatives. Read no live config here, or memoizing would freeze it.
@transient final override lazy val outputPartitioning: Partitioning = {
val childPartitioning = child.outputPartitioning
val (keyedPartitionings, otherPartitionings) =
PartitioningCollection.flatten(child.outputPartitioning)
PartitioningCollection.flatten(childPartitioning)
.partition(_.isInstanceOf[KeyedPartitioning])

val projectedKPs =
Expand All @@ -44,7 +49,7 @@ trait PartitioningPreservingUnaryExecNode extends UnaryExecNode
// deep projection chain that nesting overflows the stack when the partitioning is later
// serialized or deeply traversed.
(projectedKPs ++ projectedOthers).take(aliasCandidateLimit).toList match {
case Seq() => UnknownPartitioning(child.outputPartitioning.numPartitions)
case Seq() => UnknownPartitioning(childPartitioning.numPartitions)
case Seq(p) => p
case ps => PartitioningCollection.fromPartitionings(ps)
}
Expand Down
5 changes: 4 additions & 1 deletion ...re/src/main/scala/org/apache/spark/sql/execution/datasources/v2/GroupPartitionsExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ case class GroupPartitionsExec(
@transient enableSortedMerge: Boolean = false
) extends UnaryExecNode {

override def outputPartitioning: Partitioning = {
// A `lazy val` because the planner asks a node for its partitioning many times, and this body
// rebuilds every `KeyedPartitioning` in the child's on top of the already memoized `grouping`.
// Read no live config here, or memoizing would freeze it.
@transient override lazy val outputPartitioning: Partitioning = {
child.outputPartitioning match {
case p: Partitioning with Expression =>
// There can be multiple `KeyedPartitioning`s in an output partitioning of a join, but they
Expand Down