[SPARK-58881][CORE] Ignore non-numeric checkpoint part files - #58535
Open
charliec05 wants to merge 1 commit into
Open
[SPARK-58881][CORE] Ignore non-numeric checkpoint part files#58535charliec05 wants to merge 1 commit into
charliec05 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tighten the checkpoint directory scan so it accepts only file names consisting of
part-followed by one or more ASCII digits. The existing numeric ordering and contiguous partition validation remain unchanged.Add a regression test that creates a valid checkpoint, adds
part-00000.bak,part-backup, andpart-files, and verifies that the checkpoint can still be recovered.Why are the changes needed?
ReliableCheckpointRDD.getPartitionscurrently accepts every name starting withpart-and then parses the suffix as an integer. Leftover or externally created files such aspart-00000.baktherefore cause an unhelpfulNumberFormatExceptionand make an otherwise valid checkpoint unreadable.Spark's own checkpoint files always use a numeric suffix. Ignoring non-numeric names avoids that failure without changing validation for malformed numeric checkpoint layouts.
Does this PR introduce any user-facing change?
Yes. Reading a checkpoint directory now ignores non-numeric
part-*files. Numeric checkpoint files continue to be validated for the expected names and contiguous partition sequence.How was this patch tested?
Added a regression test and ran:
build/sbt "core/Test/testOnly org.apache.spark.CheckpointStorageSuite"All 9 tests passed. Also ran
dev/lint-scala; Scalastyle and Scalafmt passed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)