Skip to content

[SPARK-58316][SQL] Reject non-finite decimal casts in ANSI mode #58534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charliec05 wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −3
Open

[SPARK-58316][SQL] Reject non-finite decimal casts in ANSI mode #58534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,7 +1406,7 @@ case class Cast(
b => try {
changePrecision(Decimal(fractional.toDouble(b)), target)
} catch {
case _: NumberFormatException => null
case _: NumberFormatException => errorOrNull(b, from, target)
}
case x: DayTimeIntervalType =>
buildCast[Long](_, dt =>
Expand Down Expand Up @@ -1943,15 +1943,24 @@ case class Cast(
"""
case x: FractionalType =>
// All other numeric types can be represented precisely as Doubles
(c, evPrim, evNull) =>
(c, evPrim, evNull) => {
val overflow = if (ansiEnabled) {
val fromDt = ctx.addReferenceObj("from", from, from.getClass.getName)
val toDt = ctx.addReferenceObj("to", target, target.getClass.getName)
code"""throw QueryExecutionErrors.castingCauseOverflowError(
$c, $fromDt, $toDt);"""
} else {
code"$evNull = true;"
}
code"""
try {
Decimal $tmp = Decimal.apply(scala.math.BigDecimal.valueOf((double) $c));
${changePrecision(tmp, target, evPrim, evNull, canNullSafeCast, ctx)}
} catch (java.lang.NumberFormatException e) {
$evNull = true;
$overflow
}
"""
}
case x: DayTimeIntervalType =>
(c, evPrim, evNull) =>
val u = IntervalUtils.getClass.getCanonicalName.stripSuffix("$")
Expand Down
21 changes: 21 additions & 0 deletions ...talyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOnSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,27 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
cast(Literal(134.12), DecimalType(3, 2)), "cannot be represented")
}

test("SPARK-58316: casting non-finite floating values to decimal") {
val targetType = DecimalType(38, 2)
Seq(
(Literal(Float.NaN), "NaN"),
(Literal(Float.PositiveInfinity), "Infinity"),
(Literal(Float.NegativeInfinity), "-Infinity"),
(Literal(Double.NaN), "NaN"),
(Literal(Double.PositiveInfinity), "Infinity"),
(Literal(Double.NegativeInfinity), "-Infinity")
).foreach { case (literal, value) =>
checkErrorInExpression[SparkArithmeticException](
cast(literal, targetType),
"CAST_OVERFLOW",
Map(
"value" -> value,
"sourceType" -> s"\"${literal.dataType.sql}\"",
"targetType" -> s"\"${targetType.sql}\"",
"ansiConfig" -> "\"spark.sql.ansi.enabled\""))
}
}

test("ANSI mode: disallow type conversions between Numeric types and Date type") {
import DataTypeTestUtils.numericTypes
checkInvalidCastFromNumericTypeToDateType()
Expand Down