[SPARK-59253][UDF] Fix direct dispatcher interrupt race - #58525
Open
haiyangsun-db wants to merge 1 commit into
Open
[SPARK-59253][UDF] Fix direct dispatcher interrupt race#58525haiyangsun-db wants to merge 1 commit into
haiyangsun-db wants to merge 1 commit into
Conversation
Capture and clear an interrupt that races with lifecycle notification so dispatcher cleanup completes before close restores the interrupt status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Capture and clear an interrupt that races with lifecycle notification in
DirectWorkerDispatcher.awaitInFlightOperations().The interrupt is checked after leaving the
lifecycleLock.synchronizedblock.Thread.interrupted()is evaluated first so the interrupt flag is alwayscleared.
close()restores the interrupt after cleanup completes.Why are the changes needed?
lifecycleLock.wait()may return normally after notification while anoverlapping interrupt leaves the thread's interrupt flag set. Subsequent
cleanup may then fail with
InterruptedExceptionbefore it completes.Does this PR introduce any user-facing change?
No. The affected UDF worker functionality is unreleased and experimental.
How was this patch tested?
The existing regression test passed 40 consecutive runs:
DirectWorkerDispatcherSuite: interrupted close completes cleanup before restoring the interruptThe full
DirectWorkerDispatcherSuitealso passed with all 34 tests successful.Was this patch authored or co-authored using generative AI tooling?
Yes.