Skip to content

Remove Crave CI workflow; generalize SolrJ test workflow - #5350

Closed
dsmiley wants to merge 2 commits into
apache:mainfrom
dsmiley:remove-crave
Closed

dsmiley wants to merge 2 commits into
apache:mainfrom
dsmiley:remove-crave

Conversation

@dsmiley

@dsmiley dsmiley commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Crave is shutting down permanently, so this removes its references and generalizes the SolrJ GitHub workflow.

  • Delete tests-via-crave.yml
  • Drop the stale crave comment in gradle-extraction-check.yml
  • Rename solrj-test.yml to solr-test.yml; it now runs ./gradlew test (45 min timeout) on PRs touching solr/**/src/** or gradle/libs.versions.toml, the paths crave covered

🤖 Generated with Claude Code

…tests

Crave is shutting down. Delete tests-via-crave.yml and its stale reference in gradle-extraction-check.yml. Rename solrj-test.yml to solr-test.yml and run the full `test` task on the paths crave covered.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Automated PR readiness judgements (LLM-generated; may be wrong; not updated on later pushes).

@dsmiley dsmiley added this to the 9.x milestone Nov 15, 2026

@dsmiley dsmiley left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Crave is shutting down today, November 15th.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this workflow be removed entirely now since, presumably, the solr-test workflow will run with Docker and run all tests? CC @janhoy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all extraction tests have been run, so yea.

Comment thread .github/workflows/solr-test.yml Outdated

runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 45

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather choose 30 TBH. I guess we'll see how much is needed when the checks run now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh... who knows how long it would take on this 4-cpu machine; it was cancelled after 45 :-(

@dsmiley

dsmiley commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Meanwhile... finding an alternative: https://issues.apache.org/jira/browse/INFRA-28667

@nick-boss-tech

Copy link
Copy Markdown
Contributor

LGTM.

@janhoy janhoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.

A though I got when reviewing though, don't know if it will fly. Instead of removing the existing dedicated extraction and solrj workflows, replacing them with this 45min full run, we could go the opposite direction, adding one workflow per module, each scoped to that module's source files. We could let each module's workflow also trigger on libs.versions.toml so we get a complete run on dependency upgrades.

A free benefit is that we get paralellism for free. We could even register one solr-core-tests-1 and solr-core-test-2 workflows, both with the same triggers, but scoped to half of the core packages each, to gain further parallellization.

For most PRs only one or a few workflows will run, preserving runner resources. For full runs, we'll perhaps achieve the whole suite run in 15min in parallel, still not spending more runner-minutes than for a serial run?

@janhoy

janhoy commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

A PR for a parallel / per-module test approach is now up at #5354

@dsmiley dsmiley closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants