Repository navigation
Conversation
…tests Crave is shutting down. Delete tests-via-crave.yml and its stale reference in gradle-extraction-check.yml. Rename solrj-test.yml to solr-test.yml and run the full `test` task on the paths crave covered. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Automated PR readiness judgements (LLM-generated; may be wrong; not updated on later pushes).
|
dsmiley
left a comment
There was a problem hiding this comment.
Note: Crave is shutting down today, November 15th.
There was a problem hiding this comment.
Should this workflow be removed entirely now since, presumably, the solr-test workflow will run with Docker and run all tests? CC @janhoy
There was a problem hiding this comment.
Looks like all extraction tests have been run, so yea.
|
|
||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| timeout-minutes: 45 |
There was a problem hiding this comment.
I'd rather choose 30 TBH. I guess we'll see how much is needed when the checks run now.
There was a problem hiding this comment.
sigh... who knows how long it would take on this 4-cpu machine; it was cancelled after 45 :-(
|
Meanwhile... finding an alternative: https://issues.apache.org/jira/browse/INFRA-28667 |
|
LGTM. |
janhoy
left a comment
There was a problem hiding this comment.
This looks ok.
A though I got when reviewing though, don't know if it will fly. Instead of removing the existing dedicated extraction and solrj workflows, replacing them with this 45min full run, we could go the opposite direction, adding one workflow per module, each scoped to that module's source files. We could let each module's workflow also trigger on libs.versions.toml so we get a complete run on dependency upgrades.
A free benefit is that we get paralellism for free. We could even register one solr-core-tests-1 and solr-core-test-2 workflows, both with the same triggers, but scoped to half of the core packages each, to gain further parallellization.
For most PRs only one or a few workflows will run, preserving runner resources. For full runs, we'll perhaps achieve the whole suite run in 15min in parallel, still not spending more runner-minutes than for a serial run?
|
A PR for a parallel / per-module test approach is now up at #5354 |
🤖 Crave is shutting down permanently, so this removes its references and generalizes the SolrJ GitHub workflow.
tests-via-crave.ymlgradle-extraction-check.ymlsolrj-test.ymltosolr-test.yml; it now runs./gradlew test(45 min timeout) on PRs touchingsolr/**/src/**orgradle/libs.versions.toml, the paths crave covered🤖 Generated with Claude Code