SOLR-18332: More 'qt' removal, rd 4 - #4731
Open
gerlowskija wants to merge 7 commits into
Open
Conversation
The 'qt' parameter and several related methods in SolrJ are deprecated. This deprecation may not stick, but it's still worth minimizing use of this feature as much as possible. Many tests rely on it unnecessarily; this PR is one in a number of batches slowly removing these usages. This one focuses on solr-core tests that dispatch through the req()/assertQ/assertJQ/assertQEx helpers; passing the handler explicitly instead of embedding it as a 'qt' request param.
Replaces a number of 'qt' usages with the new reqWithPath helper function, this time focusing mainly on suggest and spellcheck related tests in solr-core.
epugh
approved these changes
Aug 13, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Less "oh wow, that is so nice to read: then the earlier rounds, but I guess to be expected!
Extends the reqWithPath conversion to the real-time-get, recovery, and
versions test files, replacing req("qt", "/get", ...) with
reqWithPath("/get", ...) so these tests no longer rely on the
deprecated qt parameter to select the handler.
Continues the reqWithPath conversion into the update-processor tests (AtomicUpdatesTest, NestedAtomicUpdateTest, TestDocBasedVersionConstraints, TestInPlaceUpdatesStandalone, TestUpdate), the /get-based schema tests (BooleanFieldTest, TestPointFields, TestPseudoReturnFields), and a mix of other req()+assertQ call sites (AlternateDirectoryTest, RequestHandlersTest, SegmentsInfoRequestHandlerTest, LukeRequestHandlerTest, MinimalSchemaTest, DisMaxRequestHandlerTest, PhrasesIdentificationComponentTest, ResponseLogComponentTest) that relied on the deprecated qt parameter to select a handler.
Contributor
Author
|
(Check and tests pass locally for me, just as a reminder for when I aim to merge this eventually) |
epugh
reviewed
Aug 13, 2026
| "multi boost query", | ||
| req( | ||
| reqWithPath( | ||
| qt, |
Contributor
There was a problem hiding this comment.
I wonder if the parameter qt can be renamed to path? Just from readnig the diff, I think this is now a variable holding the specific path?
epugh
reviewed
Aug 13, 2026
| "q", "foo:bar", | ||
| "omitHeader", "false"), | ||
| reqWithPath( | ||
| handler, // this should be fairly innocuous for any type of query |
Contributor
There was a problem hiding this comment.
i wonder if using the Solr specific term handler still makes sense, or we should just say path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'qt' parameter and several related methods in SolrJ are deprecated.
This deprecation may not stick, but it's still worth minimizing use of this
feature as much as possible.
Many tests rely on it unnecessarily; this PR is one in a number of batches
slowly removing these usages. This batch in particular is focused on
removing QT usage in solr-core tests, particularly those for the "suggest"
and "spellcheck" features along with a number of lingering '/get' tests and
usages.