Skip to content

nyc_taxis: make the fixed-interval histogram 60 days wide, on the epoch grid #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-bzhezytskyy wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

nyc_taxis: make the fixed-interval histogram 60 days wide, on the epoch grid #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions nyc_taxis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ parameters.
## Search operations

The following named operations are defined in `operations/default.json` and used by the test
procedures above:
procedures above. In the notes, *upstream* means OpenSearch Benchmark's `nyc_taxis`
([opensearch-benchmark-workloads](https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/nyc_taxis)),
which these operations were ported from. Elastic's `rally-tracks` carries a workload of the same
name but with different values in places — `fixed_interval: 10d` and `calendar_interval: week`
where OpenSearch Benchmark has `60d` and `month` — so the two are not interchangeable as a
reference.

| Operation | Query | Notes |
|-----------|-------|-------|
Expand All @@ -104,7 +109,7 @@ procedures above:
| `distance_amount_facet` | `trip_distance:[0 TO 50}` + range facet | Range facet on `trip_distance`. Exclusive upper bound, matching the upstream `lt: 50` |
| `date_histogram_facet` | Date range, `+1DAY` gap | Daily dropoff histogram, all 21 days of Jan 2015. Upstream bounds this with `lte: 21/01/2015` in `dd/MM/yyyy`, which covers the whole of the 21st, so the filter runs to `2015-01-22T00:00:00Z` exclusive |
| `date_histogram_calendar_interval` | Date range, `+1MONTH` gap | Monthly histogram, calendar-aligned buckets. Exclusive upper bound, matching the upstream `lt: 2016-01-01` |
| `date_histogram_fixed_interval` | Date range, `+30DAY` gap | Monthly histogram, fixed-width buckets. Exclusive upper bound, matching the upstream `lt: 2016-01-01` |
| `date_histogram_fixed_interval` | Date range, `+60DAY` gap | Fixed-width buckets, 60 days each, matching the upstream `fixed_interval: 60d`. OpenSearch anchors a fixed interval on the epoch rather than on the query, so the facet starts at `2014-11-06T00:00:00Z` — the last 60-day boundary at or before the corpus — which puts the bucket edges on the same instants. Exclusive upper bound, matching the upstream `lt: 2016-01-01` |
| `desc_sort_tip_amount` | `*:*` sort `tip_amount desc` | Descending sort |
| `asc_sort_tip_amount` | `*:*` sort `tip_amount asc` | Ascending sort |
| `desc_sort_passenger_count` | `*:*` sort `passenger_count desc` | Descending sort |
Expand Down
4 changes: 2 additions & 2 deletions nyc_taxis/operations/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
"dropoffs_over_time": {
"type": "range",
"field": "dropoff_datetime",
"gap": "+30DAY",
"gap": "+60DAY",
"mincount": 1,
"start": "2015-01-01T00:00:00Z",
"start": "2014-11-06T00:00:00Z",
"end": "2016-01-01T00:00:00Z"
}
}
Expand Down