Skip to content

fix: add namespace_id filter to app_auth selectByCondition (#6828) - #7000

Open
zhang-arvin wants to merge 1 commit into
apache:masterfrom
zhang-arvin:fix/6828-app-auth-namespace-id
Open

fix: add namespace_id filter to app_auth selectByCondition (#6828)#7000
zhang-arvin wants to merge 1 commit into
apache:masterfrom
zhang-arvin:fix/6828-app-auth-namespace-id

Conversation

@zhang-arvin

Copy link
Copy Markdown
Contributor

Fixes #6828

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Adds a namespace_id filter to the app_auth selectByCondition query, continuing the namespace-isolation hardening series (see #7001, #7007, #7003, #6999). When condition.namespaceId is provided, the query restricts results to that namespace.

Verification

  • AppAuthQuery has a namespaceId field with getter/setter (verified on master), so condition.namespaceId in the mapper resolves correctly.
  • This is a pure additive <if> condition in app-auth-sqlmap.xml; it does not change any method signature and has no callers to update.
  • Consistent with the existing pattern used for selector/plugin/discovery queries.

Conclusion

Minimal, well-scoped SQL change consistent with the surrounding namespace-isolation work. Approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] app_auth selectByCondition omits namespace_id — cross-namespace app-auth read

2 participants