fix: add namespace_id filter to app_auth selectByCondition (#6828) - #7000
Open
zhang-arvin wants to merge 1 commit into
Open
fix: add namespace_id filter to app_auth selectByCondition (#6828)#7000zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
…ache#6828) Signed-off-by: zhang-arvin <arvin.zhang@htx-inc.com>
Aias00
approved these changes
Sep 1, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Summary
Adds a namespace_id filter to the app_auth selectByCondition query, continuing the namespace-isolation hardening series (see #7001, #7007, #7003, #6999). When condition.namespaceId is provided, the query restricts results to that namespace.
Verification
AppAuthQueryhas anamespaceIdfield with getter/setter (verified onmaster), socondition.namespaceIdin the mapper resolves correctly.- This is a pure additive
<if>condition inapp-auth-sqlmap.xml; it does not change any method signature and has no callers to update. - Consistent with the existing pattern used for
selector/plugin/discoveryqueries.
Conclusion
Minimal, well-scoped SQL change consistent with the surrounding namespace-isolation work. Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6828