Skip to content

fix: correct namespace user relation batch save bindings(#6869) - #6991

Open
juicewcode wants to merge 1 commit into
apache:masterfrom
juicewcode:fix/6869-admin-namespace-user-rel-batch-save-binding
Open

fix: correct namespace user relation batch save bindings(#6869)#6991
juicewcode wants to merge 1 commit into
apache:masterfrom
juicewcode:fix/6869-admin-namespace-user-rel-batch-save-binding

Conversation

@juicewcode

Copy link
Copy Markdown
Contributor

Fixes #6869
Fix the incorrect foreach item bindings in namespace-user-rel-sqlmap.xml.

The batchSave statement declares namespaceUserRelDO as its foreach item, but its five parameter bindings referenced the unrelated namespacePluginRelDO variable. This would cause MyBatis parameter binding to fail if batchSave is invoked.

Changes

  • Replace five namespacePluginRelDO.* bindings with namespaceUserRelDO.*.
  • Add a mapper XML regression test to verify:
    • the expected foreach item is declared;
    • all five fields use namespaceUserRelDO;
    • no namespacePluginRelDO binding remains.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PermissionServiceImpl event handlers pass unguarded empty list to IN() delete — SQL syntax error

1 participant