fix: apply modify response rules to streaming responses - #6990
Open
liudawang001 wants to merge 1 commit into
Open
fix: apply modify response rules to streaming responses#6990liudawang001 wants to merge 1 commit into
liudawang001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened?
ModifyResponseDecoratoronly overrideswriteWith().For streaming responses such as SSE and NDJSON, WebFlux invokes
writeAndFlushWith(), which previously bypassedmodifyResponseHeadersAndStatus(). As a result, configured response headersand status codes were not applied.
What does this PR do?
Override
writeAndFlushWith()inModifyResponseDecoratorand invokemodifyResponseHeadersAndStatus()before delegating the original streamingbody.
The body is neither aggregated nor modified, so the original streaming and
flush behavior is preserved.
Tests
Added a regression test covering the
writeAndFlushWith()path.Verified that:
header is not applied.
shenyu-plugin-modify-responsepass.git diff --checkpasses.Fixes #6659
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.