fix(broker): reject timer delays that overflow the absolute delivery time

[GerardGao]

Which Issue(s) This PR Fixes

• Fixes [Bug] Overflowing relative timer delays can be treated as immediate #10872

Brief Description

HookUtils.transformTimerMessage converted relative timer delays (TIMER_DELAY_SEC / TIMER_DELAY_MS) into an absolute delivery timestamp with unchecked long multiplication and addition. A very large delay such as Long.MAX_VALUE overflowed into a past timestamp, bypassed the future-delivery validation, and took the immediate-message path instead of being rejected.

This change uses Math.multiplyExact / Math.addExact for the conversion. The existing catch (Exception) in the method turns the resulting ArithmeticException into PutMessageStatus.WHEEL_TIMER_MSG_ILLEGAL, so an unrepresentable delay is now rejected. It also snapshots System.currentTimeMillis() once per invocation so the conversion and the future-delivery check share the same time base.

How Did You Test This Change?

• New HookUtilsTimerOverflowTest with three cases:
  • TIMER_DELAY_SEC = Long.MAX_VALUE is rejected with WHEEL_TIMER_MSG_ILLEGAL;
  • TIMER_DELAY_MS = Long.MAX_VALUE is rejected with WHEEL_TIMER_MSG_ILLEGAL;
  • a delay that does not overflow but exceeds timerMaxDelaySec is still rejected (covers the future-delivery branch).
• On the unfixed code the overflow cases fail (the message takes the immediate path); after the fix all three pass.
• mvn -pl broker -am test: 763 tests, 0 failures (the single unrelated BrokerOuterAPITest error is a JDK 17 module-access issue in the test constructor, absent under the project's CI JDK 8).
• New patch lines are fully covered by the added tests.

[RockteMQ-AI]

Summary

Fixes an integer overflow in HookUtils.transformTimerMessage where large relative timer delays (e.g. Long.MAX_VALUE) could wrap around to a past timestamp and bypass validation. The fix uses Math.multiplyExact/Math.addExact to detect overflow, and the existing catch (Exception) converts the ArithmeticException to WHEEL_TIMER_MSG_ILLEGAL. Also snapshots currentTimeMillis() once per invocation for a consistent time base.

Clean, well-scoped fix with good regression test coverage. LGTM.

---

Automated review by github-manager-bot

[codecov-commenter]

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.51%. Comparing base (484b7b8) to head (f2427de).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ava/org/apache/rocketmq/broker/util/HookUtils.java	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10965      +/-   ##
=============================================
- Coverage      48.57%   48.51%   -0.06%     
+ Complexity     13667    13657      -10     
=============================================
  Files           1381     1381              
  Lines         101475   101480       +5     
  Branches       13189    13190       +1     
=============================================
- Hits           49293    49238      -55     
- Misses         46183    46214      +31     
- Partials        5999     6028      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[GerardGao]

Updated in f2427de to address the codecov feedback: added testTimerDelaySecAddExactOverflowRejected (addExact overflow after multiplyExact succeeds) and testTimerDelayMsSuccessPath, and split the nested exact-math expression in HookUtils so each overflow source is independently testable. Local check: mvn -pl broker -Dtest=HookUtilsTimerOverflowTest test → 5 tests, 0 failures, and all changed lines are now covered.

Note: the new commit's workflow runs are waiting for maintainer approval (action_required), so CI hasn't run yet on f2427de.

[RockteMQ-AI]

Summary

Re-reviewed after new commit f2427de6 which adds test coverage for the timer delay overflow fix. The production code change in HookUtils.transformTimerMessage correctly uses Math.multiplyExact / Math.addExact to detect overflow, with exceptions caught by the existing error handler returning WHEEL_TIMER_MSG_ILLEGAL. The new tests cover both overflow paths and the success path.

LGTM — clean fix with good test coverage.

---

Automated review by github-manager-bot