Skip to content

[ISSUE #383]: the broker information was incorrectly displayed as undefined on cluster Page.#384

Open
Gaoyan1999 wants to merge 2 commits into
apache:masterfrom
Gaoyan1999:fix-issue-383
Open

[ISSUE #383]: the broker information was incorrectly displayed as undefined on cluster Page.#384
Gaoyan1999 wants to merge 2 commits into
apache:masterfrom
Gaoyan1999:fix-issue-383

Conversation

@Gaoyan1999

@Gaoyan1999 Gaoyan1999 commented Nov 13, 2025

Copy link
Copy Markdown

What is the purpose of the change

Fix an undefined case on the Cluster Page (#383).

Brief changelog

Added missing i18n translations for MASTER and SLAVE in both Chinese and English locales (frontend-new/src/i18n/index.js)

Verifying this change

before
image
after
screenshot-20251113-212909

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Gaoyan1999 Gaoyan1999 changed the title fix: the broker information was incorrectly displayed as undefined on… [ISSUE #383]: the broker information was incorrectly displayed as undefined on cluster Page. Nov 13, 2025

@oss-sentinel-ai oss-sentinel-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✅

PR: #384 — [ISSUE #383]: broker information incorrectly displayed as undefined on cluster Page
Type: Bug fix — i18n (1 file, +5/-1)

Assessment

Adds missing i18n entries for cluster page broker information display. Fixes #383.

Verdict

✅ Clean i18n fix.


🤖 Automated review by oss-sentinel-ai

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

Adds missing i18n translations for MASTER and SLAVE keys in both Chinese and English locales to fix undefined display on the Cluster Page.

Findings

  • [Info] frontend-new/src/i18n/index.js — The translation keys are added in both zh and en sections. The values (Master / Slave) are consistent across locales, which is correct since these are technical terms typically not translated.

  • [Info] The fix directly addresses issue #383 where broker role information displayed as undefined on the cluster page.

Suggestions

  • Consider whether zh locale should use Chinese translations (e.g., 主节点 / 从节点) instead of English Master / Slave for consistency with other Chinese UI elements. This is a minor UX consideration.
  • No unit test needed for i18n additions. LGTM.

Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants