[ISSUE #383]: the broker information was incorrectly displayed as undefined on cluster Page.#384
[ISSUE #383]: the broker information was incorrectly displayed as undefined on cluster Page.#384Gaoyan1999 wants to merge 2 commits into
Conversation
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #384 — [ISSUE #383]: broker information incorrectly displayed as undefined on cluster Page
Type: Bug fix — i18n (1 file, +5/-1)
Assessment
Adds missing i18n entries for cluster page broker information display. Fixes #383.
Verdict
✅ Clean i18n fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Adds missing i18n translations for MASTER and SLAVE keys in both Chinese and English locales to fix undefined display on the Cluster Page.
Findings
-
[Info]
frontend-new/src/i18n/index.js— The translation keys are added in bothzhandensections. The values (Master/Slave) are consistent across locales, which is correct since these are technical terms typically not translated. -
[Info] The fix directly addresses issue #383 where broker role information displayed as
undefinedon the cluster page.
Suggestions
- Consider whether
zhlocale should use Chinese translations (e.g.,主节点/从节点) instead of EnglishMaster/Slavefor consistency with other Chinese UI elements. This is a minor UX consideration. - No unit test needed for i18n additions. LGTM.
Automated review by github-manager-bot
What is the purpose of the change
Fix an undefined case on the Cluster Page (#383).
Brief changelog
Added missing i18n translations for
MASTERandSLAVEin both Chinese and English locales (frontend-new/src/i18n/index.js)Verifying this change
before


after
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.