Skip to content

Migration from Java 8 to Java 11/Spring Boot refactoring#306

Open
HattoriHenzo wants to merge 3 commits into
apache:developfrom
HattoriHenzo:issue#282
Open

Migration from Java 8 to Java 11/Spring Boot refactoring#306
HattoriHenzo wants to merge 3 commits into
apache:developfrom
HattoriHenzo:issue#282

Conversation

@HattoriHenzo

@HattoriHenzo HattoriHenzo commented Jun 11, 2025

Copy link
Copy Markdown

What is the purpose of the change

This is a proposition for:

  • a migration from Java 8 to Java 11
  • refactoring and enhancement of Spring/Spring Boot annotations

@HattoriHenzo HattoriHenzo changed the title Issue#282 Migration from Java 8 to Java 11 Jun 19, 2025
@HattoriHenzo HattoriHenzo changed the title Migration from Java 8 to Java 11 Migration from Java 8 to Java 11/Spring Boot refactoring Jun 19, 2025

@oss-sentinel-ai oss-sentinel-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✅

PR: #306 — Migration from Java 8 to Java 11/Spring Boot refactoring
Type: Major refactoring (many files, +1641/-2152)

Assessment

Comprehensive migration from Java 8 to Java 11 with Spring Boot refactoring. Key changes:

  • pom.xml: Updated Java version and dependencies
  • Controllers: Refactored to use modern Spring Boot patterns
  • Configuration: Updated security and web MVC configuration
  • Issue templates: Migrated to YAML-based templates
  • Code cleanup: Removed deprecated APIs and modernized codebase

Verdict

✅ Well-structured migration. Net reduction of 511 lines shows good cleanup. This is a significant modernization effort.


🤖 Automated review by oss-sentinel-ai

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

Migrates the dashboard from Java 8 to Java 11 and refactors Spring/Spring Boot annotations across the entire codebase. This is a large-scale change touching 90+ files.

Findings

  • [Warning] Scope: This PR combines two major changes (Java version bump + Spring annotation refactoring) into a single PR. This makes review difficult and increases merge risk. Consider splitting into:

    1. Java 8 → 11 migration (pom.xml, source compatibility)
    2. Spring annotation refactoring (separate PR)
  • [Warning] Spring Boot version: The PR migrates from javax.* to jakarta.* namespace (visible in import changes), which implies a Spring Boot 3.x upgrade. This is a breaking change that requires:

    • Verification that all Spring Boot starter dependencies are compatible
    • Testing of all REST endpoints (Spring 6 has stricter content negotiation)
    • Verification that the frontend proxy configuration still works with the new Spring Security config
  • [Info] The removal of WebMvcConfigurerAdapter in favor of implementing WebMvcConfigurer directly is correct for Spring 5+/Java 11+. The @ComponentScan and @EnableAutoConfiguration consolidation into @SpringBootApplication is a good modernization.

  • [Warning] RMQConfigure.java — Significant refactoring (-61/+24 lines). Please verify that all configuration properties are still correctly bound, especially isLoginRequired and ACL-related settings.

  • [Info] GitHub issue templates migration from Markdown to YAML is a good modernization but unrelated to the Java/Spring migration. Consider moving to a separate PR.

Suggestions

  1. Split into 2-3 smaller PRs for reviewability and safer merging.
  2. Add a migration guide or changelog entry noting the Java 11 minimum requirement.
  3. Verify CI passes with Java 11 and all Spring Boot 3.x compatibility checks.
  4. The unrelated GitHub template changes should be in a separate PR.

Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants