QPIDJMS-616: enhance error message to include additional info from errorCondition#55
QPIDJMS-616: enhance error message to include additional info from errorCondition#55vm-karthik wants to merge 2 commits into
Conversation
|
Hello @gemmellr, Can you please review this ? I have already created a JIRA Bug for this : https://issues.apache.org/jira/browse/QPIDJMS-616 Please pardon me if I am tagging a wrong person of if correct process has not been followed here. Kindly let me know the process, if wrong.. |
| if (info != null && !info.isEmpty()) { | ||
| messageWithInfo = message + " [info = " + info + "]"; | ||
| } | ||
| return messageWithInfo; |
There was a problem hiding this comment.
Is there any chance that the map returned by the errorCondition.getInfo() contains privileged information? Specifically contents of something read from disk or unobfuscated passwords or access tokens or similar?
There was a problem hiding this comment.
I wouldnt expect that, but its up to the peer to decide what they put in there so its impossible to say what might be in there. Typically nothing, hence whey no client I know of thus far does whats proposed.
|
I have previously looked at this. I dont think its a good idea adding the arbitrary map toString to the exception message, especially not just because a particular service has decided not to use either of the two other more direct ways to usefully describe the actual reason they are erroring, in form of the error description and condition (and to boot whilst misusing the core spec not-allowed condition). I have not had time to look at alternatives. |
4 participants
Enhance error message to include additional info from errorCondition