Fix pdfbox 5876 - #525
Open
valerybokov wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: bound that metadata-only read to a fixed, sane subsampling (8 — matching the max PageDrawer.getSubsampling() ever requests anyway) instead of either "no limit" or MAX_VALUE. reader.getWidth(0)/getHeight(0) are unaffected by subsampling, so dimensions stay exact; only the resolution of an embedded soft mask (SMaskInData, rare) is affected, and it's already rescaled elsewhere.
Changes are currently uncommitted on trunk: pdfbox/pom.xml (new test-fixture download entry), PDImageXObject.java (the fix), TestQuality.java + new JPXLowMemoryRenderMain.java (the regression test).
Per https://www.apache.org/legal/generative-tooling.html: portions of this PR were
produced with assistance from Claude Code (Anthropic), based on a bug was described in Apache PDFBOX Issue Tracker.
I've reviewed the generated code and confirm to the best of my knowledge that the output does not include any
third-party copyrighted material and is compatible with the Apache License 2.0.