Skip to content

[core] Fix IS NAN predicate failing with file index #9143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −0
Open

[core] Fix IS NAN predicate failing with file index #9143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ public FileIndexResult visitIsNull(FieldRef fieldRef) {
return REMAIN;
}

@Override
public FileIndexResult visitIsNaN(FieldRef fieldRef) {
return REMAIN;
}

@Override
public FileIndexResult visitStartsWith(FieldRef fieldRef, Object literal) {
return REMAIN;
Expand Down
27 changes: 27 additions & 0 deletions paimon-common/src/test/java/org/apache/paimon/fileindex/FileIndexPredicateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@

package org.apache.paimon.fileindex;

import org.apache.paimon.fileindex.bloomfilter.BloomFilterFileIndex;
import org.apache.paimon.options.Options;
import org.apache.paimon.predicate.CompoundPredicate;
import org.apache.paimon.predicate.Equal;
import org.apache.paimon.predicate.LeafPredicate;
import org.apache.paimon.predicate.Or;
import org.apache.paimon.predicate.Predicate;
import org.apache.paimon.predicate.PredicateBuilder;
import org.apache.paimon.predicate.PredicateVisitor;
import org.apache.paimon.types.DataTypes;
import org.apache.paimon.types.RowType;
Expand All @@ -34,8 +37,11 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.Set;

import static org.apache.paimon.fileindex.FileIndexResult.REMAIN;
import static org.apache.paimon.fileindex.bloomfilter.BloomFilterFileIndexFactory.BLOOM_FILTER;
import static org.assertj.core.api.Assertions.assertThat;

/** Test for {@link FileIndexPredicate}. */
Expand All @@ -54,6 +60,27 @@ public void testGetRequiredNamesVisitsEachChildOnce() throws Exception {
assertThat(right.visitCount).isEqualTo(1);
}

@Test
public void testIsNaNWithBloomFilter() throws Exception {
RowType rowType = RowType.builder().field("d", DataTypes.DOUBLE()).build();
FileIndexWriter indexWriter =
new BloomFilterFileIndex(DataTypes.DOUBLE(), new Options()).createWriter();
indexWriter.writeRecord(Double.NaN);

Map<String, Map<String, byte[]>> indexes = new HashMap<>();
indexes.computeIfAbsent("d", column -> new HashMap<>())
.put(BLOOM_FILTER, indexWriter.serializedBytes());

ByteArrayOutputStream baos = new ByteArrayOutputStream();
try (FileIndexFormat.Writer writer = FileIndexFormat.createWriter(baos)) {
writer.writeColumnIndexes(indexes);
}

try (FileIndexPredicate predicate = new FileIndexPredicate(baos.toByteArray(), rowType)) {
assertThat(predicate.evaluate(new PredicateBuilder(rowType).isNaN(0))).isSameAs(REMAIN);
}
}

@SuppressWarnings("unchecked")
private static Set<String> getRequiredNames(Predicate predicate) throws Exception {
Method method =
Expand Down
Loading