[core] Fix file index pushdown for bitmap64 deletion vectors - #9141
Open
QuakeWang wants to merge 2 commits into
Open
[core] Fix file index pushdown for bitmap64 deletion vectors#9141QuakeWang wants to merge 2 commits into
QuakeWang wants to merge 2 commits into
Conversation
File index limit and TopN selections only excluded 32-bit deletion vectors, so bitmap64 deletions could reduce pushed-down results after reading. Large files could also force unsupported 32-bit position selections. Project bounded bitmap64 positions for file indexes, fall back when positions cannot be represented, and enforce limits after deletion-vector filtering. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Resolve the FileIndexEvaluator overlap with apache#9088 and preserve file metadata through limit readers. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FileIndexEvaluatoronly excluded 32-bit deletion vectors when building limit and TopN selections. With bitmap64 deletion vectors, pushed-down selections could include deleted rows and return fewer rows than requested. Large files could also require positions that cannot be represented by 32-bit bitmaps.This change adds bounded bitmap64 projection with a safe fallback, filters deletion-vector positions during file-index evaluation, and reapplies the final limit after deletion-vector filtering.
Tests
paimon-coretests, Checkstyle, Spotless, Enforcer, and RAT.