Skip to content

[common] Fix missing rows for null range bitmap indexes #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Open

[common] Fix missing rows for null range bitmap indexes #9140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions paimon-common/src/main/java/org/apache/paimon/fileindex/rangebitmap/RangeBitmap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public RoaringBitmap32 isNotNull() {

private RoaringBitmap32 isNull(@Nullable RoaringBitmap32 foundSet) {
if (cardinality <= 0) {
return rid > 0 ? RoaringBitmap32.bitmapOf(0, rid - 1) : new RoaringBitmap32();
return rid > 0 ? RoaringBitmap32.bitmapOfRange(0, rid) : new RoaringBitmap32();
}

if (foundSet != null && foundSet.isEmpty()) {
Expand Down Expand Up @@ -306,7 +306,7 @@ private RoaringBitmap32 fillNulls(
@Nullable RoaringBitmap32 foundSet,
BiFunction<Integer, RoaringBitmap32, RoaringBitmap32> function) {
if (cardinality <= 0) {
return rid > 0 ? RoaringBitmap32.bitmapOf(0, rid - 1) : new RoaringBitmap32();
return rid > 0 ? RoaringBitmap32.bitmapOfRange(0, rid) : new RoaringBitmap32();
}

RoaringBitmap32 bitmap;
Expand Down
11 changes: 8 additions & 3 deletions ...ommon/src/test/java/org/apache/paimon/fileindex/rangebitmap/RangeBitmapFileIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,9 @@ public void testOnlyNulls() {
FieldRef fieldRef = new FieldRef(0, "", intType);
RangeBitmapFileIndex bitmapFileIndex = new RangeBitmapFileIndex(intType, new Options());
FileIndexWriter writer = bitmapFileIndex.createWriter();
writer.writeRecord(null);
writer.writeRecord(null);
for (int i = 0; i < 5; i++) {
writer.writeRecord(null);
}

// build index
byte[] bytes = writer.serializedBytes();
Expand All @@ -433,7 +434,7 @@ public void testOnlyNulls() {

// test is null
assertThat(((BitmapIndexResult) reader.visitIsNull(fieldRef)).get())
.isEqualTo(RoaringBitmap32.bitmapOf(0, 1));
.isEqualTo(RoaringBitmap32.bitmapOfRange(0, 5));
// test is not null
assertThat(((BitmapIndexResult) reader.visitIsNotNull(fieldRef)).get())
.isEqualTo(RoaringBitmap32.bitmapOf());
Expand All @@ -444,6 +445,10 @@ public void testOnlyNulls() {
// test GT
assertThat(((BitmapIndexResult) reader.visitGreaterThan(fieldRef, 0)).get())
.isEqualTo(RoaringBitmap32.bitmapOf());

TopN topN = new TopN(fieldRef, ASCENDING, NULLS_FIRST, 1);
assertThat(((BitmapIndexResult) reader.visitTopN(topN, null)).get())
.isEqualTo(RoaringBitmap32.bitmapOfRange(0, 5));
}

@Test
Expand Down
Loading