Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
LanceRecordsWriter.close()flushes the final Arrow batch before closing the native Lance writer and the Arrow writer. If that final flush throws, the method returns immediately and both writer resources are skipped.MosaicRecordsWriter, the other native Arrow-backedBundleFormatWriterimplementation, already continues its cleanup after a flush failure while preserving the first failure and attaching later failures as suppressed exceptions.What changes
Apply the same failure-path cleanup semantics to
LanceRecordsWriter:The normal close order is unchanged.
Tests
LanceRecordsWriterTest#testCloseContinuesCleanupAfterFlushFailureverifies that a flush failure does not skip either close, and that later close failures are preserved as suppressed exceptions. The test fails with the production change reverted and passes with this fix.The full
LanceRecordsWriterTestsuite passes 6/6. Spotless and checkstyle are clean,git diff --checkpasses, and the module compiles withmaven.compiler.release=8.API and Format
No change.