Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#9227 made
AbstractFileStoreWrite.close()close every writer and shut down its executors before rethrowing the first writer failure. The subclasses above it still callsuper.close()first and release their own resources afterwards, so that rethrown failure skips:MemoryFileStoreWrite: the writer buffer metric groupBaseAppendFileStoreWrite: the blob fetch metricsKeyValueFileStoreWrite: the compact manager factory, whoseclose()invalidates the lookup file cacheThese classes back both append-only and primary-key tables.
What changes
Close the parent and the subclass resource with
IOUtils.closeAll, the helper #9227 uses. The first failure is rethrown with later ones attached as suppressed. AnErrorstill propagates immediately.Tests
AbstractFileStoreWriteCloseTestadds an append-only and a primary-key case in which a writer fails to close. Both fail on master because the outer cleanup never runs, and both pass with the fix. Reverting any one of the three classes fails its case.BucketedAppendFileStoreWriteTestandKeyValueFileStoreWriteTestpass; spotless and checkstyle are clean.API and Format
No change.