Skip to content

[core] Improve BUCKET_APPEND_ORDERED test coverage - #10049

Merged
JingsongLi merged 1 commit into
apache:masterfrom
atlassian-forks:dwang/bucket-append-ordered-test
Sep 22, 2026
Merged

JingsongLi merged 1 commit into
apache:masterfrom
atlassian-forks:dwang/bucket-append-ordered-test

Conversation

@dwangatt

Copy link
Copy Markdown
Contributor

Purpose

Extracted from #9370, which is being split into smaller, independently reviewable PRs.

This PR contains only test coverage improvements for BUCKET_APPEND_ORDERED. It is independent of the per-partition bucket-count feature.

Changes

  • Retain the existing restore-failure coverage when manifest files are unavailable.
  • Add focused sequence-number assertions for ordered and unordered bucketed append writes:
    • ordered mode restores previous files and continues sequence numbers;
    • unordered write-only mode skips restore and starts sequence numbers from zero.

Testing

  • AppendOnlySimpleTableTest#testBucketedAppendOrderedSequenceNumbers
  • AppendOnlySimpleTableTest#testBucketedAppendUnorderedSequenceNumbers

Related

@JingsongLi

Copy link
Copy Markdown
Contributor

Requirement fit: SUPPORTED. The two-commit test checks an observable file contract: ordered bucketed append continues sequence numbers, while unordered write-only mode starts a new sequence. This covers behavior that the existing missing-manifest test does not assert. Implementation: CLEAN in this test-only diff. I did not rerun the core test locally.

@JingsongLi
JingsongLi merged commit 8fc0df7 into apache:master Sep 22, 2026
18 checks passed
@dwangatt
dwangatt deleted the dwang/bucket-append-ordered-test branch September 22, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants