fix(spec): default PartitionStatistics totalBuckets when absent - #986
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
`PartitionStatistics::total_buckets` had no serde default, so deserializing statistics that omit `totalBuckets` — e.g. produced by an older Paimon version that predates the field, which a REST catalog may still return — failed with a missing-field error instead of reading the rest of the record. Java treats the field as `@JsonProperty` on a primitive `int` and documents that it "defaults to 0 if absent (older Paimon version)". Add `#[serde(default)]` so the field falls back to 0, matching Java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartitionStatistics::total_bucketshad no serde default, so deserializing statistics that omittotalBuckets— e.g. produced by an older Paimon version that predates the field, which a REST catalog may still return during a mixed-version deployment — failed with a missing-field error instead of reading the record.Java declares the field as
@JsonPropertyon a primitiveintand documents that it "defaults to 0 if absent (older Paimon version)". Add#[serde(default)]so the Rust struct falls back to 0 the same way.A test deserializes a payload without
totalBucketsand asserts it reads as 0; it fails with a missing-field error before the change.