perf(scan): prune index manifest entries - #703
Merged
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
| // Keep malformed entries so the scanner can preserve fail-loud validation. | ||
| return Ok(true); | ||
| }; | ||
| Ok(predicate_field_ids.contains(&global_index.index_field_id) |
Contributor
There was a problem hiding this comment.
Malformed index_meta for an unrelated sorted index is pruned before validation, so it no longer fails loudly as described in the PR.
Member
Author
There was a problem hiding this comment.
@XiaoHongbo-Hope Good catch. This is intentional: unrelated indexes are pruned before index_meta validation, matching Java. I've updated the PR description to clarify the fail-loud scope.
Contributor
|
+1 |
XiaoHongbo-Hope
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Scan planning retained index-manifest entries that could not affect the query, including DELETE entries, deletion vectors from unselected partitions, and sorted global indexes unrelated to predicate fields. These entries were ignored later but still increased planning CPU and memory usage.
Brief change log
Tests
cargo fmt --all -- --checkcargo clippy --locked --all-targets --workspace --features fulltext,vortex -- -D warningscargo test --locked -p paimon --all-targets --features fulltext,vortexcargo test -p paimon-datafusion --test procedures test_create_global_indexAPI and Format
Documentation