fix(table): list the supported formats when a format table is rejected - #702
Open
jackylee-ch wants to merge 1 commit into
Open
fix(table): list the supported formats when a format table is rejected#702jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A format table with an unreadable
file.formatreports only the rejected value, so the usercannot tell which formats are available — and the sets differ from Java in both directions
(Java has CSV/TEXT/JSON, Rust has
.row), so the Java docs do not answer it either. Java'sFormatTable.parseFormatappends the supported list.Fix: build the message from a
supported_format_table_formats()helper, as #690 just didfor the write side. Also documents the
global-index.thread-numupper bound added by #647,which the doc comment and the option table still omit.
Adding CSV/TEXT/JSON support is out of scope. Adds the first tests to
format_table_scan.rs.