Revert object storage backends change#352
Closed
JingsongLi wants to merge 1 commit into
Closed
Conversation
This reverts commit eae0761.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts
eae07614ea6f5e578bf5974214afdca703f8b496/ #346 because main CI started hanging after the object storage backend changes landed. The hang is reproducible in GitHub Actions on Ubuntu in the Vortex reader tests and the DataFusion Vortex integration test.Changes
Testing
cargo test -p paimon arrow::format::vortex::tests::test_vortex_read_with --all-targets --features fulltext,vortex -- --nocapturecargo test -p paimon-datafusion --features vortex --test vortex_tables -- --nocaptureNotes
Main CI hangs after #346 in:
arrow::format::vortex::tests::test_vortex_read_with_combined_predicatesarrow::format::vortex::tests::test_vortex_read_with_empty_projectionarrow::format::vortex::tests::test_vortex_read_with_eq_predicatearrow::format::vortex::tests::test_vortex_read_with_gt_predicatetests/vortex_tables.rs::test_vortex_file_format_sql_e2eThis revert is intended to unblock main while the Linux-specific Vortex/OpenDAL interaction is investigated separately.