HDDS-16006. Fix S3 PutBucketLifecycleConfiguration compatibility test failures - #10883
Open
priyeshkaratha wants to merge 1 commit into
Open
HDDS-16006. Fix S3 PutBucketLifecycleConfiguration compatibility test failures#10883priyeshkaratha wants to merge 1 commit into
priyeshkaratha wants to merge 1 commit into
Conversation
priyeshkaratha
marked this pull request as ready for review
July 28, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PutBucketLifecycleConfiguration was rejecting three classes of valid S3 lifecycle configurations with HTTP 400, causing 5 failures in the S3 compatibility test suite:
OmLCExpiration.valid()rejected anyDatevalue earlier than the configuration's creation time. The S3 spec allows past dates; they mean objects should expire immediately and are commonly used in configuration templates.OmLCExpiration.valid()to throw "Either 'days' or 'date' should be specified" → HTTP 400.NoncurrentVersionExpirationended up with an empty actions list, failing the "At least one action" check → HTTP 400.Changes Made
ExpiredObjectDeleteMarkerto the Expiration JAXB class andNoncurrentVersionExpirationto the Rule JAXB class. Rules whose only actions are unsupported elements are skipped when building the OmLifecycleConfiguration. If all rules in the request are unsupported-only, the gateway returns HTTP 200 without persisting (accept-but-ignore semantics matching AWS behavior).What is the link to the Apache JIRA
HDDS-16006
How was this patch tested?
Added new testcases for failed cases.