HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. - #10880
Open
ptlrs wants to merge 1 commit into
Conversation
…les to fix invalid testCompile configurations in IntelliJ.
adoroszlai
requested changes
Jul 28, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ptlrs for the patch. run config fix looks good, but the pom changes should be avoided.
Comment on lines
+1844
to
+1854
| <execution> | ||
| <id>default-testCompile</id> | ||
| <goals> | ||
| <goal>testCompile</goal> | ||
| </goals> | ||
| <configuration> | ||
| <compilerArgs> | ||
| <arg>-AartifactId=${project.artifactId}</arg> | ||
| </compilerArgs> | ||
| </configuration> | ||
| </execution> |
Contributor
There was a problem hiding this comment.
These testCompile configurations cause warnings, please don't add them. See HDDS-14789.
[INFO] --- compiler:3.15.0:testCompile (default-testCompile) @ hdds-cli-common ---
...
[WARNING] The following options were not recognized by any processor: '[project]'
[INFO] --- compiler:3.15.0:testCompile (default-testCompile) @ hdds-client ---
...
[WARNING] The following options were not recognized by any processor: '[artifactId]'
adoroszlai
reviewed
Jul 28, 2026
| <configuration default="false" name="ScmRoles" type="Application" factoryName="Application"> | ||
| <option name="MAIN_CLASS_NAME" value="org.apache.hadoop.ozone.admin.OzoneAdmin" /> | ||
| <module name="ozone-tools" /> | ||
| <module name="ozone-cli-admin" /> |
| <configuration default="false" name="FreonStandalone" type="Application" factoryName="Application"> | ||
| <option name="MAIN_CLASS_NAME" value="org.apache.hadoop.ozone.freon.Freon" /> | ||
| <module name="ozone-tools" /> | ||
| <module name="ozone-freon" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The run configurations in Intellij are invalid. This can be seen from the little red cross marks on the run configurations. The error says that the class in the run configuration doesn't exist in the class path.
Since Intellij 2025.1 release, the way Intellij processes pom files has changed. It creates separate .main and .test modules in Maven projects.
See https://youtrack.jetbrains.com/projects/IDEA/issues/IDEA-371535/Confusing-separate-.main-and-.test-modules-in-Maven-projects
If there is a difference between the main and test configurations, then Intellij will create separate main and test modules. As such the default classpath won't work. The run configurations are pointing to classes which are not in the default classpath but instead in the classpath with the .main suffix.
This PR adds a
default-testCompilefor the test sections to bring them on par with the main configurations. After this Intellij doesn't split the module intomainandtestand the existing run configurations become valid again.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16001
How was this patch tested?
Tested locally
CI: https://github.com/ptlrs/ozone/actions/runs/30307554649