Skip to content

Improved: Introduce a Gradle version catalog for dependency versions (OFBIZ-13487) - #1606

Merged
mridulpathak merged 1 commit into
apache:trunkfrom
mridulpathak:OFBIZ-13487
Aug 9, 2026
Merged

Improved: Introduce a Gradle version catalog for dependency versions (OFBIZ-13487)#1606
mridulpathak merged 1 commit into
apache:trunkfrom
mridulpathak:OFBIZ-13487

Conversation

@mridulpathak

Copy link
Copy Markdown
Contributor

Extracts dependencies.gradle's ~98 scattered dependency-version literals into a new
gradle/libs.versions.toml Gradle version catalog, with zero change in resolved
dependency versions -- verified via an empty before/after dependency-tree diff and a
full build + test run. Plugin-local dependencies (e.g. plugins/ldap) are untouched;
the catalog covers only core-framework/shared dependencies. settings.gradle is also
untouched: its two plugin versions can't use the catalog, since Gradle evaluates that
file's plugins {} block before any version catalog exists (gradle/gradle#24876,
closed not-planned).

…IZ-13487)

Extract dependencies.gradle's ~98 version literals into gradle/libs.versions.toml.
settings.gradle is untouched -- its plugin versions can't use the catalog, since
Gradle evaluates that block before any catalog exists. No version changes.
@mridulpathak
mridulpathak merged commit 0c07edb into apache:trunk Aug 9, 2026
7 checks passed
@jacopoc

jacopoc commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Hi @mridulpathak

Did you check if, with the new format, Dependabot is still producing pull requests to keep the dependencies updated or if any configuration changes are required to our GitHub actions to allow it?
For example, I have noticed that Dependabot has recently created a few pull requests to bump Swagger in the rest-api component of the release branch (in which the component is under plugins, but this is irrelevant): see for example apache/ofbiz-plugins#355
However I don't see an equivalent pull request for the framework trunk.

@mridulpathak

Copy link
Copy Markdown
Contributor Author

Hi @mridulpathak

Did you check if, with the new format, Dependabot is still producing pull requests to keep the dependencies updated or if any configuration changes are required to our GitHub actions to allow it? For example, I have noticed that Dependabot has recently created a few pull requests to bump Swagger in the rest-api component of the release branch (in which the component is under plugins, but this is irrelevant): see for example apache/ofbiz-plugins#355 However I don't see an equivalent pull request for the framework trunk.

Hi @jacopoc

I ran Dependabot manually for build.gradle and it produced two PRS #1610 and #1611 with the new setup as expected. I noticed there are a lot of failed PR generations from before due to GitHub's default limit of 5. Would it be wise to configure a higher limit in depandabot.yml? Also, all the open framework dependabot PRs are now stale with new changes, I'll go ahead and close them.
LastRun
LastRunError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants