Fixed: isExecutable() missed Tika's ELF sub-types, letting real Linux binaries through the check (OFBIZ-13486) - #1600
Merged
Conversation
… binaries through the check (OFBIZ-13486) SecuredUpload.isExecutable() only matched the generic mimeType "application/x-elf", but Tika (verified against tika-core:3.3.1) classifies real ELF binaries into more specific sub-types instead -- "application/x-executable", "application/x-sharedlib", "application/x-object", "application/x-coredump" -- so actual executables and shared libraries passed the check undetected. Adds the four sub-types to the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecuredUpload.isExecutable() only matched the generic mimeType application/x-elf, but Tika (verified against tika-core:3.3.1) classifies real ELF binaries into more specific sub-types instead — application/x-executable, application/x-sharedlib, application/x-object, application/x-coredump — so actual executables and shared libraries passed the check undetected. Confirmed with two real ELF files (a JNA native .so and a JDK's bin/java PIE executable), both detected as application/x-sharedlib and missed by the old check. Adds the four sub-types to the check.