-
Notifications
You must be signed in to change notification settings - Fork 157
docs: rewrite expected-checksums.md to STE rules #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elharo
wants to merge
24
commits into
master
Choose a base branch
from
docs/ste-expected-checksums
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−132
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3447030
docs: rewrite expected-checksums.md to STE rules
elharo d97b4cf
present > history
elharo 7afa8db
Update expected-checksums.md
elharo b69467a
Update expected-checksums.md
elharo 241f01c
examples
elharo a2e266c
Update expected-checksums.md
elharo 5ca91d9
Update expected-checksums.md
elharo c647ba3
Update expected-checksums.md
elharo 8a3d4a0
Update expected-checksums.md
elharo 50b7dce
Update expected-checksums.md
elharo 1c4601a
Update expected-checksums.md
elharo a3001ad
Update expected-checksums.md
elharo 2f0685d
Update expected-checksums.md
elharo 3af3d98
Update expected-checksums.md
elharo 9a2052f
Update expected-checksums.md
elharo 9b4f047
Update expected-checksums.md
elharo c3951ae
Update expected-checksums.md
elharo c9fd260
Update expected-checksums.md
elharo 5634fbf
italics
elharo 961f870
Update expected-checksums.md
elharo 3b06494
correct key names
elharo 784e335
Update expected-checksums.md
elharo 4b11ea8
Update expected-checksums.md
elharo 74d99c1
Update expected-checksums.md
elharo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line documents
x-amz-meta-checksum-sha1andx-amz-meta-checksum-md5for AWS S3, but the codebase has no implementation for these headers.XChecksumExtractor.javaonly handles:x-checksum-sha1/x-checksum-md5x-goog-meta-checksum-sha1/x-goog-meta-checksum-md5grep -ri "amz" --include="*.java"across the entire repository returns zero results. This bullet should be removed unless code support is added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is on master, added in #2023
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, which is why I added it here. The LLM is possibly out of date or maybe looking at a wrong branch? In any case, I think this PR is ready for humna review @gnodet and I think is a huge improvement over the current state. If anything is missing we can send more PRs to improve it further. This one turned into a much bigger rewrite than I was expecting.