Skip to content

Enable IT MPMD-304-toolchain-support for maven4 #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adangel wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −12
Open

Enable IT MPMD-304-toolchain-support for maven4 #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/it/MPMD-304-toolchain-support/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,5 @@
# specific language governing permissions and limitations
# under the License.

# the jdk toolchain "11" is selected in pom.xml
invoker.toolchain.jdk.version = 11

invoker.toolchain.jdk.version = 17
invoker.goals = clean verify

# Restricting this test to maven 3 only, which is compatible with Java 8.
# With the toolchain setting, PmdExecutor will be called with Java 11
# and uses classes from Maven (e.g. MojoExecutionException). Maven 4 requires
# at least Java 17, so maven-pmd-plugin/PMD can't be executed anymore on
# Java 11.
# TODO: Make toolchain support maven4 compatible
invoker.maven.version=!4+
2 changes: 1 addition & 1 deletion src/it/MPMD-304-toolchain-support/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ under the License.

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<javaVersion>11</javaVersion>
<javaVersion>17</javaVersion>
</properties>

<build>
Expand Down
Loading